Skip to content

Conversation

@junrushao
Copy link
Member

@junrushao junrushao commented Oct 14, 2025

DO NOT MERGE

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @junrushao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request synchronizes the local tvm-ffi submodule with its upstream apache/tvm-ffi repository. The primary purpose is to integrate the latest developments and bug fixes, most notably a CMake configuration correction that improves the build process when tvm-ffi is used as a subdirectory. This ensures the project benefits from the most recent stability and compatibility improvements from the dependency.

Highlights

  • Submodule Update: The tvm-ffi submodule has been updated to the latest upstream HEAD, specifically commit 58875b99330487e3629778f00a02c2278e3ea851.
  • Upstream Fix Included: This update incorporates a critical CMake fix from the upstream apache/tvm-ffi repository, addressing issues when building as a subdirectory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tvm-ffi submodule to a newer commit. While this is a routine maintenance task, the pull request lacks a description detailing the changes included in the submodule update. This makes it difficult to assess the potential impact, such as breaking API changes, on the rest of the codebase. For improved maintainability and easier reviews, it is highly recommended to summarize the upstream changes in the pull request description.

Upstream : https://github.com/apache/tvm-ffi.git
Branch   : main
New HEAD : 1af6d9f9648bb2547d97d455bb4464d217654fc4
Subject  : feat(stubgen): Refactor into staged pipeline, Introduce directive `import` (apache#259)
Author   : Junru Shao <[email protected]>
Date     : 2025-11-15T09:38:28-08:00
Delta    : 2 commit(s) since ae346ec92a3c
Compare  : apache/tvm-ffi@ae346ec...1af6d9f

This commit updates the tvm-ffi submodule to the latest upstream HEAD.
Upstream : https://github.com/apache/tvm-ffi.git
Branch   : main
New HEAD : 92e150b9cb8222eeadf5469eae2e06400e4af850
Subject  : feat(stubgen): Generate `__all__` for proper exporting (apache#268)
Author   : Junru Shao <[email protected]>
Date     : 2025-11-16T15:44:58-08:00
Delta    : 1 commit(s) since 1af6d9f9648b
Compare  : apache/tvm-ffi@1af6d9f...92e150b

This commit updates the tvm-ffi submodule to the latest upstream HEAD.
Upstream : https://github.com/apache/tvm-ffi.git
Branch   : main
New HEAD : 70d6bf00d65a57502396989a2de565f1a54ebe4d
Subject  : Add Siyuan Feng's GPG key to KEYS file (apache#269)
Author   : Siyuan Feng <[email protected]>
Date     : 2025-11-17T11:15:35+08:00
Delta    : 1 commit(s) since 92e150b9cb82
Compare  : apache/tvm-ffi@92e150b...70d6bf0

This commit updates the tvm-ffi submodule to the latest upstream HEAD.
Upstream : https://github.com/apache/tvm-ffi.git
Branch   : main
New HEAD : 7a355c77b7e74a9ac5a1269c3c55497e88fb76a4
Subject  : [TORCH] Remove ninja dep on non-windows when JIT optional torch-c-dlpack (apache#272)
Author   : Tianqi Chen <[email protected]>
Date     : 2025-11-17T10:16:52-05:00
Delta    : 1 commit(s) since 70d6bf00d65a
Compare  : apache/tvm-ffi@70d6bf0...7a355c7

This commit updates the tvm-ffi submodule to the latest upstream HEAD.
Upstream : https://github.com/apache/tvm-ffi.git
Branch   : main
New HEAD : 889bfb360b5afa6f7b50774cba53e7e625ea1e8f
Subject  : [Minor] use perfect forwarding for template types. (apache#266)
Author   : DarkSharpness <[email protected]>
Date     : 2025-11-17T23:22:24+08:00
Delta    : 1 commit(s) since 7a355c77b7e7
Compare  : apache/tvm-ffi@7a355c7...889bfb3

This commit updates the tvm-ffi submodule to the latest upstream HEAD.
Upstream : https://github.com/apache/tvm-ffi.git
Branch   : main
New HEAD : dd3de0746b50009091a0ecc3e63bfcf2e4a2da94
Subject  : [TEST] Add test for Optional<TensorView> (apache#274)
Author   : Tianqi Chen <[email protected]>
Date     : 2025-11-17T10:45:17-05:00
Delta    : 1 commit(s) since 889bfb360b5a
Compare  : apache/tvm-ffi@889bfb3...dd3de07

This commit updates the tvm-ffi submodule to the latest upstream HEAD.
Upstream : https://github.com/apache/tvm-ffi.git
Branch   : main
New HEAD : 74f53c5710220285ce5f25ad7a09dcfdd683c72f
Subject  : [BUILD][MINOR] Remove --no-as-needed (apache#276)
Author   : Tianqi Chen <[email protected]>
Date     : 2025-11-17T13:52:10-05:00
Delta    : 2 commit(s) since dd3de0746b50
Compare  : apache/tvm-ffi@dd3de07...74f53c5

This commit updates the tvm-ffi submodule to the latest upstream HEAD.
Upstream : https://github.com/apache/tvm-ffi.git
Branch   : main
New HEAD : 7cd2e500f5f17079ac6bdf7bf4f79681c885714a
Subject  : [chore] Hide symbols by default for extension build (apache#278)
Author   : Tianqi Chen <[email protected]>
Date     : 2025-11-18T10:37:52-05:00
Delta    : 1 commit(s) since 74f53c571022
Compare  : apache/tvm-ffi@74f53c5...7cd2e50

This commit updates the tvm-ffi submodule to the latest upstream HEAD.
Upstream : https://github.com/apache/tvm-ffi.git
Branch   : main
New HEAD : a999de6efa7f59b6a120ddc1b762eafc290d45a6
Subject  : fix: clang tidy issue (apache#279)
Author   : Kathryn (Jinqi) Chen <[email protected]>
Date     : 2025-11-20T18:41:34-08:00
Delta    : 3 commit(s) since 7cd2e500f5f1
Compare  : apache/tvm-ffi@7cd2e50...a999de6

This commit updates the tvm-ffi submodule to the latest upstream HEAD.
Upstream : https://github.com/apache/tvm-ffi.git
Branch   : main
New HEAD : 8dbd28112cddbaeeffa26420b1dee98a582a7cd7
Subject  : [TORCH] Fix precise version of f8e8m0 support (apache#282)
Author   : Tianqi Chen <[email protected]>
Date     : 2025-11-21T20:01:22-05:00
Delta    : 1 commit(s) since a999de6efa7f
Compare  : apache/tvm-ffi@a999de6...8dbd281

This commit updates the tvm-ffi submodule to the latest upstream HEAD.
Upstream : https://github.com/apache/tvm-ffi.git
Branch   : main
New HEAD : d49effdb22392363050e1f2d85cd4b31bf242cf0
Subject  : [Feature] Add cubin launcher utility as an extra header (apache#283)
Author   : Yaoyao Ding <[email protected]>
Date     : 2025-11-25T18:35:33-05:00
Delta    : 1 commit(s) since 8dbd28112cdd
Compare  : apache/tvm-ffi@8dbd281...d49effd

This commit updates the tvm-ffi submodule to the latest upstream HEAD.
Upstream : https://github.com/apache/tvm-ffi.git
Branch   : main
New HEAD : cdfd04109f74a2115c909302f4adf90536bce865
Subject  : Add cuda DeviceGuard (apache#287)
Author   : Yaxing Cai <[email protected]>
Date     : 2025-11-25T19:19:53-08:00
Delta    : 1 commit(s) since d49effdb2239
Compare  : apache/tvm-ffi@d49effd...cdfd041

This commit updates the tvm-ffi submodule to the latest upstream HEAD.
Upstream : https://github.com/apache/tvm-ffi.git
Branch   : main
New HEAD : 7f3bb77155645f90f7d221889b3795704ffd7d6f
Subject  : [DLPACK] Upgrade DLPack Exchange API to pass by capsule (apache#288)
Author   : Tianqi Chen <[email protected]>
Date     : 2025-11-26T17:44:26-05:00
Delta    : 1 commit(s) since cdfd04109f74
Compare  : apache/tvm-ffi@cdfd041...7f3bb77

This commit updates the tvm-ffi submodule to the latest upstream HEAD.
Upstream : https://github.com/apache/tvm-ffi.git
Branch   : main
New HEAD : 803cdc84a4bb4502c8da0e5f69a61c1e7b1a38cf
Subject  : [DOCS] Update kernel library guide with device guard (apache#289)
Author   : Yaxing Cai <[email protected]>
Date     : 2025-11-26T16:04:00-08:00
Delta    : 1 commit(s) since 7f3bb7715564
Compare  : apache/tvm-ffi@7f3bb77...803cdc8

This commit updates the tvm-ffi submodule to the latest upstream HEAD.
Upstream : https://github.com/apache/tvm-ffi.git
Branch   : main
New HEAD : 5e6547497cf4b7a90c6352413324416b25d2b64a
Subject  : chore(release): Add GPG Key from Junru Shao (apache#290)
Author   : Junru Shao <[email protected]>
Date     : 2025-11-26T20:57:07-08:00
Delta    : 1 commit(s) since 803cdc84a4bb
Compare  : apache/tvm-ffi@803cdc8...5e65474

This commit updates the tvm-ffi submodule to the latest upstream HEAD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant