-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[CI] Move conda config files to tests/conda and remove unused conda build infrastructure #18456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @tlopex, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's continuous integration and development environment by reorganizing existing Conda configuration files into a more appropriate Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides a solid cleanup by reorganizing conda-related files and removing unused conda build infrastructure. The changes are consistent and well-executed. Moving the environment configuration to tests/conda is a logical improvement, and all references across the codebase, including CI workflows, ownership files, and scripts, have been updated accordingly. This refactoring enhances the project's maintainability by removing obsolete components. The changes are approved.
|
cc @tqchen |
guan404ming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, thanks!
|
cc @tqchen |
Summary
This PR reorganizes the conda-related files and removes unused conda build infrastructure.
Changes
Moved Files
conda/build-environment.yaml→tests/conda/build-environment.yamlconda/condarc→tests/conda/condarcRemoved Files
conda/build_cpu.sh,conda/build_cuda.sh,conda/build_win.bat(build scripts)conda/recipe/(entire directory with conda package recipes)conda/Dockerfile.template,conda/render_cuda_dockerfiles.pyUpdated References
.github/actions/setup/action.yml- Updated paths to referencetests/conda/tests/lint/blocklint.sh- Removed reference to deletedconda/recipe/meta.yamlversion.py- Removed conda recipe version sync logicci/scripts/jenkins/git_skip_ci_globs.py- Removedconda/*from skip globs.github/CODEOWNERSHIP- Updated ownership path totests/conda/**