Skip to content

WICKET-7141 Add hook method afterUpdateFormComponentModels() in Form process #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WICKET-7141 Add hook method afterUpdateFormComponentModels() in Form process #1087

wants to merge 1 commit into from

Conversation

florianlacreuse
Copy link

No description provided.

@florianlacreuse florianlacreuse force-pushed the ft-form-process-hook branch 2 times, most recently from e804027 to bba3544 Compare February 24, 2025 15:50
reiern70
reiern70 reviewed Apr 22, 2025
View reviewed changes
Copy link
Contributor

@reiern70 reiern70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me but maybe I'm not the best person to approve these changes. Maybe add some tests covering these changes?

@florianlacreuse
Copy link
Author

Hi @reiern70. Thanks for taking the time to look at my PR.

I've just improved the existing FormVisitTest to take these 2 new behaviors (before/after in post order) into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reiern70 reiern70 reiern70 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianlacreuse @reiern70