Skip to content

Conversation

@PDavid
Copy link
Contributor

@PDavid PDavid commented Oct 16, 2025

Reviewers: anmolnar
Author: PDavid
Closes #2322 from PDavid/ZOOKEEPER-3938-jline-upgrade-branch-3.9

(cherry picked from commit a9b1904)

Reviewers: anmolnar
Author: PDavid
Closes apache#2322 from PDavid/ZOOKEEPER-3938-jline-upgrade-branch-3.9

(cherry picked from commit a9b1904)
@PDavid
Copy link
Contributor Author

PDavid commented Oct 16, 2025

This is the backport of #2318 to branch-3.8.

The patch did not apply cleanly on branch-3.9 because of a slight local variable name difference in ZooKeeperMain.run(): "completer" vs. "completor" so I cherry-picked the branch-3.9 commit: a9b1904

Tested this locally the same way as described in the original PR:
#2318 (comment)

@PDavid
Copy link
Contributor Author

PDavid commented Oct 16, 2025

ReadOnlyModeTest.testConnectionEvents failed in the PR build with timeout. Locally it was successful for me.

@PDavid PDavid marked this pull request as ready for review October 16, 2025 15:54
Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants