Skip to content

Remove mock requirement and update coveralls version #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

tofu-rocketry
Copy link
Member

No description provided.

@tofu-rocketry tofu-rocketry added this to the 4.0.0 milestone Nov 28, 2024
@tofu-rocketry tofu-rocketry self-assigned this Nov 28, 2024
@tofu-rocketry tofu-rocketry requested a review from a team as a code owner November 28, 2024 16:36
@tofu-rocketry tofu-rocketry added enhancement dependencies Pull requests that update a dependency file labels Nov 28, 2024
Remove mock as a test requirement as it's now part of Python from 3.3
onwards and we're dropping the last bits of Python 2 support. Unit test
updated to use new import (but maintain rest of code).
Copy link
Member

@Sae126V Sae126V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adrian. I see that you have used unittest.mock than the mock itself. cool

@tofu-rocketry tofu-rocketry merged commit ae67193 into apel:dev Nov 29, 2024
11 checks passed
@tofu-rocketry tofu-rocketry deleted the remove-mock-req branch November 29, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Development

Successfully merging this pull request may close these issues.

None yet

2 participants