Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-pup: Verify with openssl instead of sha256sum #138

Merged
merged 1 commit into from
May 10, 2022

Conversation

ryandesign
Copy link
Contributor

@ryandesign ryandesign commented May 9, 2022

Use openssl to verify download because sha256sum does not exist on macOS.

If there are systems that have sha256sum but not openssl, then this could be rewritten to use whichever of those is present.

Use openssl to verify download because sha256sum does not exist on
macOS.
Copy link
Owner

@aperezdc aperezdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a good idea, we can expect OpenSSL will be installed because it's a dependency of Nginx itself, needed anyway in order to build and run tests. Thanks for the patch, @ryandesign 👌🏼

@aperezdc aperezdc merged commit 698e7ce into aperezdc:master May 10, 2022
@ryandesign ryandesign deleted the ryandesign-get-pup branch May 10, 2022 18:59
@ryandesign
Copy link
Contributor Author

Well nginx can be built without ssl support, and the version you build for tests is built that way. Still, openssl is very popular and is probably installed.

Of course, this PR doesn't solve the problem that the pup binary that gets downloaded for macOS just crashes immediately and has to be rebuilt from source (by downloading and extracting the pup source and running go build in its directory), but one thing at a time. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants