feat(doctrine): new iri search filters #7121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinceAmstoutz
force-pushed
the
feat/new-doctrine-iri-search-filters
branch
from
0271e3e to
774ba0c
Compare
vinceAmstoutz
force-pushed
the
feat/new-doctrine-iri-search-filters
branch
4 times, most recently
from
8322356 to
773ce67
Compare
vinceAmstoutz
force-pushed
the
feat/new-doctrine-iri-search-filters
branch
4 times, most recently
from
ae2ad0e to
662ad04
Compare
soyuka
reviewed
Jul 1, 2025
soyuka
reviewed
Jul 1, 2025
soyuka
reviewed
Jul 1, 2025
soyuka
reviewed
Jul 1, 2025
continues the work at api-platform#6865
Continues the work at api-platform#7079 and before at api-platform#6865
Continues the work at api-platform#7079 and before at api-platform#6865
Continues the work at api-platform#7079 and before at api-platform#6865
Continues the work at api-platform#7079 and before at api-platform#6865
Continues the work at api-platform#7079 and before at api-platform#6865
Continues the work at api-platform#7079 and before at api-platform#6865
Continues the work at api-platform#7079 and before at api-platform#6865
Continues the work at api-platform#7079 and before at api-platform#6865
Continues the work at api-platform#7079 and before at api-platform#6865 See api-platform#6971.
Continues the work at api-platform#7079 and before at api-platform#6865 See api-platform#6971.
vinceAmstoutz
force-pushed
the
feat/new-doctrine-iri-search-filters
branch
from
662ad04 to
f6bbe8b
Compare
Continues the work at api-platform#7079 and before at api-platform#6865 See api-platform#6971.
Continues the work at api-platform#7079 and before at api-platform#6865 See api-platform#6971.
Continues the work at api-platform#7079 and before at api-platform#6865
soyuka
requested changes
Aug 18, 2025
| return; | ||
| } | ||
|
|
||
| $values = (array) $parameter->getValue(); |
There was a problem hiding this comment.
This is now castToArray therefore we don't really need to cast here, however we may need to fix how we build our aggregation see below
| use ApiPlatform\OpenApi\Model\Parameter as OpenApiParameter; | ||
|
|
||
| /** | ||
| * @author Vincent Amstoutz <[email protected]> |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| return new OpenApiParameter(name: $parameter->getKey().'[]', in: 'query', style: 'deepObject', explode: true); | ||
| } | ||
|
|
||
| public function getDescription(string $resourceClass): array |
There was a problem hiding this comment.
Let's move this method to a trait inside Metadata, also add * @deprecated in 4.2, to be removed in 5.0 to the Metadata\FilterInterface (we'll handle the bc later)
Comment on lines
+39
to
+42
| $aggregationBuilder | ||
| ->match() | ||
| ->field($property) | ||
| ->in($values); |
There was a problem hiding this comment.
Suggested change
| $aggregationBuilder | |
| ->match() | |
| ->field($property) | |
| ->in($values); | |
| $aggregationBuilder | |
| ->match() | |
| ->field($property) | |
| ->{(is_iterable($value)) ? 'in' : 'equals'}($parameter->getValue()); |
|
|
||
| $value = $parameter->getValue(); | ||
| if (!\is_array($value)) { | ||
| $value = [$value]; |
There was a problem hiding this comment.
There is now castToArray therefore we don't really need to cast here, however we may need to fix how we build our aggregation see below
| #[ODM\Document] | ||
| class Company | ||
| { | ||
| #[ODM\Id(strategy: 'INCREMENT', type: 'int')] | ||
| #[ODM\Id(type: 'int', strategy: 'INCREMENT')] |
| */ | ||
| protected function setUp(): void | ||
| { | ||
| self::$alwaysBootKernel = false; |
There was a problem hiding this comment.
protected static ?bool $alwaysBootKernel = false;| 'expectedNames' => ['Gertrude'], | ||
| ]; | ||
|
|
||
| yield 'filtre par ID du poulailler de Henriette' => [ |
There was a problem hiding this comment.
the API Platform code base is in english :p
| * @throws ServerExceptionInterface | ||
| */ | ||
| #[DataProvider('filterDataProvider')] | ||
| public function testOrFilter(string $url, int $expectedCount, array $expectedNames): void |
There was a problem hiding this comment.
I'm not sure this correctly tests an Or filter
| */ | ||
| protected function setUp(): void | ||
| { | ||
| self::$alwaysBootKernel = false; |
There was a problem hiding this comment.
protected static ?bool $alwaysBootKernel = false;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainThe aim of this PR is to have the API Platform search filters like API Platform eloquent filters.
This PR continues the improvements initiated in pull requests #7079 and #6865, aiming to finalize the efforts started initially in pull request #6775.
TODO (by order of priority) :