perf: don't bundle node:crypto in the browser bundle
#782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses new implementations of
createStorageContentSignatureandcreateHmacSignaturefrom@apify/utilities.Those native WebCrypto API instead of importing the
node:cryptopackage, so we can markcryptoas external in the browser bundler and cut the bundle size ~2.4 times (both plain and compressed).master)perf/use-native-crypto)Note:
SubtleCryptoAPI in browsers is only available in Secure Contexts. This should be fairly safe (as anyhttps://-served page is one, as well aslocalhost).Related to #753