refactor: Extract API storage client creation from the Apify storage code #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-tooling
Contributor
Author
|
Refactoring refactoring to the discussion in: |
Pijukatel
commented
Nov 5, 2025
| raw_metadata = await resource_client.get() | ||
| metadata = self._get_metadata(raw_metadata) | ||
| if not raw_metadata: | ||
| # Do we want this??? Backwards compatibility, so probably yes. |
Contributor
Author
There was a problem hiding this comment.
One edge case from the discussion
Pijukatel
commented
Nov 5, 2025
| if raw_metadata: | ||
| return resource_client, self._get_metadata(raw_metadata) | ||
| # If we do not raise here, we will behave same as for default storage. We create it even though it | ||
| # should exist already. Consistency or throw an error??? |
Contributor
Author
There was a problem hiding this comment.
The other edge case from the discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
openmethod toApiClientFactoryopenmethods of Apify storages.