Refactor C++ code into modular files and switch to setuptools build system #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystem Split the monolithic _pyensmallen.cpp file into modular components: - utils.hpp: Common utilities and wrapper classes - newton_type.hpp: L-BFGS implementation - constrained.hpp: Frank-Wolfe algorithm for constrained optimization - first_order.hpp: Adam and its variants Also updated the build system to use setuptools instead of meson for better compatibility.
Created benchmark_performance.py which: - Generalizes the likelihood_comparison notebook into a reusable script - Tests performance across different dataset sizes (n,k) - Compares pyensmallen against other popular optimization libraries - Generates visualizations and summary tables - Includes command-line options for customization This will help demonstrate pyensmallen's performance advantages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the monolithic _pyensmallen.cpp file into modular components:
Also updated the build system to use setuptools instead of meson for better compatibility.
h/t claude code