Implement Protocol-Based Testing with Sendable Conformance in AppStoreServerAPIClient #91
Conversation
Instead of initializing a http client pool, expose the httpClient through the initializer or default on .shared that way we can share the http pool with others Deinit is no longer needed since httpclient is exposed Create a configuration struct so we are able to throw when initializing config & have a non throwing client initializer
…it tests, since AppStoreServerAPIClient is a final Sendable class now
StefanPrintezis
changed the title
| // try! used for example purposes only | ||
| let client = try! AppStoreServerAPIClient(signingKey: encodedKey, keyId: keyId, issuerId: issuerId, bundleId: bundleId, environment: environment) | ||
| let config = try! AppStoreServerAPIConfiguration(signingKeyPem: encodedKey, keyId: keyId, issuerId: issuerId, bundleId: bundleId, environment: environment) | ||
| let client = AppStoreServerAPIClient(config: config) |
There was a problem hiding this comment.
Is breaking out the configuration necessary for Sendable conformance? Why was this change made
There was a problem hiding this comment.
The main goal was use a mocked http client instead of internal override func executeRequest. Sendable conformance is an addition, because why not :)
| transactionHistoryRequest.sort = TransactionHistoryRequest.Order.ascending | ||
| transactionHistoryRequest.revoked = false | ||
| transactionHistoryRequest.productTypes = [TransactionHistoryRequest.ProductType.autoRenewable] | ||
| let transactionHistoryRequest = TransactionHistoryRequest( |
There was a problem hiding this comment.
This seems unrelated to to the proposed changes in this PR
There was a problem hiding this comment.
I think this triggered a warning, since var should only be used when mutation is logically required.
| } | ||
|
|
||
| public enum APIResult<T> { | ||
| public enum APIResult<T: Sendable>: Sendable{ |
There was a problem hiding this comment.
Is this the only change in this PR necessary to actually make this Sendable?
There was a problem hiding this comment.
No, there are more Sendable conformances added in the PR.
3 participants
Summary
This PR implements a protocol-based testing approach inspired by Soto's AWSHTTPClient pattern, making AppStoreServerAPIClient conform to Sendable, and improves the overall architecture for better testability and concurrency safety.
Protocol-Based HTTP Client Architecture
Configuration Improvements
Testing
Documentation Updates