feat: color and plain modes for --progress flag #899
+110
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhantomInTheWire
force-pushed
the
feat/color-plain
branch
5 times, most recently
from
345bf01 to
c59d4d2
Compare
Contributor
|
I don't see anything out of the ordinary on these changes, but I also don't have permissions to approve PRs. You will have to wait for a maintainer to come back to this for a ✅ . |
Signed-off-by: Karan <[email protected]>
PhantomInTheWire
force-pushed
the
feat/color-plain
branch
from
c59d4d2 to
9e1b44b
Compare
Comment on lines
68
to
71
| /// The flag indicating whether to use colors. | ||
| public let color: Bool | ||
| /// The flag indicating whether to use plain output (no ANSI codes, one line per update). | ||
| public let plain: Bool |
Contributor
There was a problem hiding this comment.
Could we use an enum instead of these booleans to indicate the type of the output?
Author
There was a problem hiding this comment.
i was avoiding that since that would involve changing a widely used api would touch a lot unrelated lines but it does seem to make this a little bit more cleaner overall
Signed-off-by: Karan <[email protected]>
Author
|
@katiewasnothere @saehejkang what do you guys think about making color mode the default mode instead of ansi since it visually looks a lot more appealing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
relevant issue: #641
Adds two new modes to
--progress: plain and color.plain: Produces simple, line-by-line text output with no ANSI escape codes. Ideal for writing to log files or environments that don’t support terminal control sequences.
color: Similar to the existing ANSI mode but with enhanced color usage. This mode provides a more expressive visual display. If it sounds good, we could consider making it the default in this or a follow up pr.
Testing