Improve code maintainability, fix typos, and enhance usability #96
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bugs Fix typographical errors and use system swift
| @@ -18,7 +18,7 @@ | |||
| BUILD_CONFIGURATION ?= debug | |||
|
|
|||
| # Commonly used locations | |||
| SWIFT := "/usr/bin/swift" | |||
| SWIFT ?= $(shell command -v swift) | |||
There was a problem hiding this comment.
I think the reason this was hardcoded to explicitly use the swift wrapper binary that ships with Xcode
There was a problem hiding this comment.
Can you revert this change?
crosbymichael
requested changes
Jun 30, 2025
| @@ -18,7 +18,7 @@ | |||
| BUILD_CONFIGURATION ?= debug | |||
|
|
|||
| # Commonly used locations | |||
| SWIFT := "/usr/bin/swift" | |||
| SWIFT ?= $(shell command -v swift) | |||
There was a problem hiding this comment.
Can you revert this change?
| @@ -39,6 +39,6 @@ if [ ! -z "$2" ] ; then | |||
| opts+=("--hosting-base-path" "$2") | |||
| fi | |||
|
|
|||
| /usr/bin/swift package ${opts[@]} | |||
| "$(command -v swift)" package "${opts[@]}" | |||
There was a problem hiding this comment.
Can you revert this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to improve code maintainability, fix typos, and enhance usability. The changes include making the
swiftcommand path dynamic, correcting spelling and grammatical errors in comments, fixing a typo in a test case, and updating a script to dynamically locate theswiftexecutable.Code maintainability and usability improvements:
Makefileto dynamically locate theswiftexecutable usingcommand -v, replacing the hardcoded path. (Makefile, MakefileL21-R21)scripts/make-docs.shto usecommand -v swiftfor determining theswiftexecutable path, improving portability. (scripts/make-docs.sh, scripts/make-docs.shL42-R42)Typo and grammar fixes:
Image.swift, improving clarity. (Sources/Containerization/Image/Image.swift, Sources/Containerization/Image/Image.swiftL118-R119)Platform.swift("effictively" → "effectively"). (Sources/ContainerizationOCI/Platform.swift, Sources/ContainerizationOCI/Platform.swiftL266-R266)RegistryClientTests.swift("conatinerization" → "containerization"). (Tests/ContainerizationOCITests/RegistryClientTests.swift, Tests/ContainerizationOCITests/RegistryClientTests.swiftL297-R297)