-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fdbkubernetesmonitor: Add a check for new binaries in the shared binary directory and report them back in an annotation #12230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ry directory and report them back in an annotation
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Result of foundationdb-pr-clang on Linux RHEL 9
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Result of foundationdb-pr on Linux RHEL 9
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. How'd you test?
return err | ||
} | ||
|
||
return podClient.updateAnnotationsOnPod(map[string]string{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does a replace I presume?
for len(fdbserverBinaries) == 0 { | ||
// If after 5 minutes the new fdbserver binary was not copied, something is probably wrong. | ||
if time.Since(startTime) > 5*time.Minute { | ||
return fmt.Errorf("could not find fdbserver binary in shared binary dir after more than 2 minutes") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/2/5/
Those changes allow the operator to validate that the binaries are present before triggering a restart.
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)