Add validation function for raw signatures#284
Merged
Conversation
Motivation: Keys can be used to sign arbitrary data. Validating those signatures is currently not straight forward. Modifications: Introduce an isValidSignature overload that works with any input bytes. Add tests to verify that it works. Results: A new API to validate signatures represented as bytes.
Lukasa
reviewed
Nov 18, 2025
Co-authored-by: Cory Benfield <lukasa@apple.com>
Contributor
Author
|
Thank you for the review! I integrated your suggestions. |
Lukasa
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Signatures can be performed on any kind of data, e.g., to prove ownership of the private key for a given certificate. This data usually comes as a blob of bytes.
Modification
Add a signature verification function that operates on bytes represented by the
DataProtocol. The bytes are converted to the signature type matching the key and share an implementation with the verification function forCertificate.Signature.Result
Easy validation of signatures represented as bytes.