adds support for swift-concurrency Duration and async closures for Timer measurements #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
note: need to remove |
Member
|
@AndriusA Can you update this PR so we can start to review it? |
FranzBusch
added a commit
that referenced
this pull request
Apr 22, 2024
# Motivation This PR supersedes #135. The goal is to make it easier to measure asynchronous code when using `Metrics`. # Modification This PR does: - Deprecate the current static method for measuring synchronous code - Add a new instance method to measure synchronous code - Add a new instance method to measure asynchronous code # Result It is now easier to measure asynchronous code.
FranzBusch
added a commit
that referenced
this pull request
Mar 8, 2025
# Motivation This PR supersedes #135. The goal is to make it easier to measure asynchronous code when using `Metrics`. # Modification This PR does: - Deprecate the current static method for measuring synchronous code - Add a new instance method to measure synchronous code - Add a new instance method to measure asynchronous code # Result It is now easier to measure asynchronous code.
FranzBusch
added a commit
that referenced
this pull request
Mar 8, 2025
# Motivation This PR supersedes #135. The goal is to make it easier to measure asynchronous code when using `Metrics`. # Modification This PR does: - Deprecate the current static method for measuring synchronous code - Add a new instance method to measure synchronous code - Add a new instance method to measure asynchronous code # Result It is now easier to measure asynchronous code.
FranzBusch
added a commit
that referenced
this pull request
Mar 8, 2025
# Motivation This PR supersedes #135. The goal is to make it easier to measure asynchronous code when using `Metrics`. # Modification This PR does: - Deprecate the current static method for measuring synchronous code - Add a new instance method to measure synchronous code - Add a new instance method to measure asynchronous code # Result It is now easier to measure asynchronous code.
FranzBusch
added a commit
that referenced
this pull request
Mar 10, 2025
# Motivation This PR supersedes #135. The goal is to make it easier to measure asynchronous code when using `Metrics`. # Modification This PR does: - Deprecate the current static method for measuring synchronous code - Add a new instance method to measure synchronous code - Add a new instance method to measure asynchronous code # Result It is now easier to measure asynchronous code.
FranzBusch
added a commit
that referenced
this pull request
Mar 10, 2025
# Motivation This PR supersedes #135. The goal is to make it easier to measure asynchronous code when using `Metrics`. # Modification This PR does: - Deprecate the current static method for measuring synchronous code - Add a new instance method to measure synchronous code - Add a new instance method to measure asynchronous code # Result It is now easier to measure asynchronous code.
FranzBusch
added a commit
that referenced
this pull request
Mar 10, 2025
# Motivation This PR supersedes #135. The goal is to make it easier to measure asynchronous code when using `Metrics`. # Modification This PR does: - Deprecate the current static method for measuring synchronous code - Add a new instance method to measure synchronous code - Add a new instance method to measure asynchronous code
aluco100
reviewed
Nov 9, 2025
| var nanosecondsClamped: Int64 { | ||
| let components = self.components | ||
|
|
||
| let secondsComponentNanos = components.seconds.multipliedReportingOverflow(by: 1_000_000_000) |
There was a problem hiding this comment.
maybe this value could be guarded into a static constant since this never mutates and is being used in both secondsComponentNanos & attosCompononentNanos
aluco100
reviewed
Nov 9, 2025
Comment on lines
+117
to
+118
| !combinedNanos.overflow | ||
| else { |
There was a problem hiding this comment.
Suggested change
| !combinedNanos.overflow | |
| else { | |
| !combinedNanos.overflow else { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extends Timer with support for standard lib Duration type and measurements to relative to Instant on Clocks using Duration
Motivation:
Use of Timer is currently clunky with async code as any durations need to be manually converted to microseconds (et al)
Modifications:
Extends Timer with:
Clock.Instanton anyClockusingDurationClockor defaultContinuousClockResult:
Additional Timer methods available for measuring async work