Add makeServerConfigurationWithMTLS #286
Merged
+88
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcairo
approved these changes
Sep 16, 2025
Lukasa
reviewed
Sep 16, 2025
gjcairo
reviewed
Oct 22, 2025
| /// could not be loaded from the given paths. | ||
| public static func makeServerConfigurationWithMTLS( | ||
| certificateReloader: some CertificateReloader, | ||
| trustRoots: NIOSSLTrustRoots |
There was a problem hiding this comment.
Would it make sense to default this to the system defaults?
There was a problem hiding this comment.
Not sure about this, but I suspect most mTLS applications would require clients to present a certificate that is anchored to some custom trust root, which is not likely to be a system default trust root. If this is the case then we shouldn't default the argument to system default trust roots.
The underlying NIOSSL function that this function mirrors also doesn't have a default argument.
cc @Lukasa
There was a problem hiding this comment.
Yeah, we should not default this to the system trust roots, that will tend to be surprising.
Lukasa
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To mirror apple/swift-nio-ssl#545
This allows users to easily create a tls configuration for servers which want to do mtls, with reloading