This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Use ARG to reference version of dependencies#32
Open
masih wants to merge 1 commit intoappoptics:masterfrom
masih:use_args_in_dockerfile
Open
Use ARG to reference version of dependencies#32masih wants to merge 1 commit intoappoptics:masterfrom masih:use_args_in_dockerfile
masih wants to merge 1 commit intoappoptics:masterfrom
masih:use_args_in_dockerfile
Conversation
Beaujr
reviewed
Oct 21, 2019
| LABEL maintainer='Chris Rust <[email protected]>' | ||
|
|
||
| ENV APPOPTICS_SNAPTEL_VERSION '2.0.0-ao1.1919' | ||
| ARG APPOPTICS_SNAPTEL_VERSION='2.0.0-ao1.1919' |
Contributor
There was a problem hiding this comment.
Can args be read as environment variables as well?
If not should be something like
ARG APPOPTICS_SNAPTEL_VERSION='2.0.0-ao1.1919'
ENV APPOPTICS_SNAPTEL_VERSION=${APPOPTICS_SNAPTEL_VERSION}
Author
There was a problem hiding this comment.
Hey Beau how is it going?
During build the ARG is available as if it is an environment variable.
Outside of it, is that environment variable elsewhere during runtime? I can't find it.
Is it required that the version is available as environment variable at runtime?
Contributor
There was a problem hiding this comment.
Aye I just checked the repo, looks like its only used for the package manager in the dockerfile 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the version of
snaptelagent to change during build for debugging and development purposes.