Skip to content
This repository was archived by the owner on Dec 10, 2025. It is now read-only.

Merge MultiReporter into Reporter#81

Open
tillberg wants to merge 12 commits intomasterfrom
merge-multi-reporter
Open

Merge MultiReporter into Reporter#81
tillberg wants to merge 12 commits intomasterfrom
merge-multi-reporter

Conversation

@tillberg
Copy link
Contributor

@tillberg tillberg commented Aug 14, 2020

This adds additional configuration options to the Reporter. One of the added configuration options includes the ability to specify multiple MeasurementsCommunicators. This obviates the need for the separate MultiReporter.

This also makes a couple minor improvements:

  • Removes an old quirk: instead of sending metrics at a random offset from the minute, metrics are now sent at the top of each minute. This is probably what everyone wants and expects.
  • Adds a Close function to the Reporter that blocks for up to ~5 seconds while attempting to send a final batch of measurements to each MeasurementsCommunicator.

@tillberg tillberg closed this Sep 28, 2022
@tillberg tillberg reopened this Sep 28, 2022
@lucky
Copy link

lucky commented Sep 28, 2022

lol i got a notification for this

@dkuebric
Copy link

same 👋

@tillberg tillberg marked this pull request as ready for review October 17, 2022 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants