Skip to content

When impersonating the cluster admin, use system:admin instead of cluster-admin #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thobens merged 1 commit into from
Nov 19, 2025
Merged

When impersonating the cluster admin, use system:admin instead of cluster-admin #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions docs/modules/ROOT/pages/how-tos/migrate-cloudscale-router.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ commodore catalog compile "${CLUSTER_ID}"
+
[source,bash]
----
kubectl --as=cluster-admin -n syn patch apps root --type=json \
kubectl --as=system:admin -n syn patch apps root --type=json \
-p '[{"op":"replace", "path":"/spec/syncPolicy", "value": {}}]'
----

Expand Down Expand Up @@ -123,10 +123,10 @@ commodore catalog compile ${CLUSTER_ID}
+
[source,bash]
----
kubectl --as=cluster-admin apply -f catalog/manifests/cloudscale-loadbalancer-controller/00_namespace.yaml
kubectl --as=system:admin apply -f catalog/manifests/cloudscale-loadbalancer-controller/00_namespace.yaml
kapitan refs --reveal --refs-path catalog/refs -f catalog/manifests/cloudscale-loadbalancer-controller/10_secrets.yaml | \
kubectl --as=cluster-admin apply -f -
kubectl --as=cluster-admin apply -Rf catalog/manifests/cloudscale-loadbalancer-controller/10_kustomize
kubectl --as=system:admin apply -f -
kubectl --as=system:admin apply -Rf catalog/manifests/cloudscale-loadbalancer-controller/10_kustomize
kubectl -n appuio-cloudscale-loadbalancer-controller \
wait --for condition=available \
deploy cloudscale-loadbalancer-controller-controller-manager
Expand All @@ -137,7 +137,7 @@ kubectl -n appuio-cloudscale-loadbalancer-controller \
[source,bash]
----
yq 'del(.spec.floatingIPAddresses)' catalog/manifests/cloudscale-loadbalancer-controller/20_loadbalancers.yaml | \
kubectl --as=cluster-admin apply -f -
kubectl --as=system:admin apply -f -
----

. Wait for the cluster ingress to become reachable via the loadbalancer
Expand All @@ -146,7 +146,7 @@ yq 'del(.spec.floatingIPAddresses)' catalog/manifests/cloudscale-loadbalancer-co
----
export LB_IP=""
while [ "$LB_IP" == "" ]; do
export LB_IP=$(kubectl --as=cluster-admin -n appuio-cloudscale-loadbalancer-controller \
export LB_IP=$(kubectl --as=system:admin -n appuio-cloudscale-loadbalancer-controller \
get loadbalancer ingress -oyaml | \
yq '(.status.virtualIPAddresses[]|select(.address|contains("2a06")|not)|.address)//""')
if [ "$LB_IP" == "" ]; then
Expand Down Expand Up @@ -325,7 +325,7 @@ commodore catalog compile ${CLUSTER_ID} --push -i
+
[source,bash]
----
kubectl --as=cluster-admin -n syn patch apps root --type=json \
kubectl --as=system:admin -n syn patch apps root --type=json \
-p '[{
"op":"replace",
"path":"/spec/syncPolicy",
Expand Down