Skip to content

fix plugin #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix plugin #2015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions plugins/aws/kms/kmsKeyRotation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ module.exports = {
return;
}

if (describeKeyData.KeyMetadata && describeKeyData.KeyMetadata.KeySpec && describeKeyData.KeyMetadata.KeySpec !== 'SYMMETRIC_DEFAULT') {
noCmks = false;
helpers.addResult(results, 0, `Key rotation is not available for key spec: ${describeKeyData.KeyMetadata.KeySpec}`, region, kmsKey.KeyArn);
return;
}

var getKeyRotationStatus = helpers.addSource(cache, source,
['kms', 'getKeyRotationStatus', region, kmsKey.KeyId]);

Expand Down
28 changes: 27 additions & 1 deletion plugins/aws/kms/kmsKeyRotation.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,23 @@ const describeKey = [
Origin: "AWS_KMS"
}
},
{
KeyMetadata: {
AWSAccountId: "111122223333",
Arn: "arn:aws:kms:us-east-1:111122223333:key/60c4f21b-e271-4e97-86ae-6403618a9467",
CreationDate: "2020-08-26T16:55:28+00:00",
CustomerMasterKeySpec: "HMAC_512",
Description: "",
Enabled: true,
KeyId: "60c4f21b-e271-4e97-86ae-6403618a9467",
KeyManager: "CUSTOMER",
KeyState: "Enabled",
KeyUsage: "ENCRYPT_DECRYPT",
MultiRegion: false,
Origin: "AWS_KMS",
KeySpec: "HMAC_512",
}
},
{
KeyMetadata: {
AWSAccountId: "111122223333",
Expand Down Expand Up @@ -206,6 +223,15 @@ describe('kmsKeyRotation', function () {
});
});

it('should PASS if Key Rotation is not available for KMS Key', function (done) {
const cache = createCache([listKeys], describeKey[2], keyPolicy[0], keyRotationStatus[0]);
kmsKeyRotation.run(cache, {}, (err, results) => {
expect(results.length).to.equal(1);
expect(results[0].status).to.equal(0);
done();
});
});

it('should FAIL if KMS has encryption greater than awskms and has rotation disabled', function (done) {
const cache = createCache([listKeys], describeKey[1], keyPolicy[0], keyRotationStatus[1]);
kmsKeyRotation.run(cache, {}, (err, results) => {
Expand Down Expand Up @@ -235,7 +261,7 @@ describe('kmsKeyRotation', function () {
});

it('should pass if KMS encryption level is lower than or equal to awskms', function (done) {
const cache = createCache([listKeys], describeKey[2], keyPolicy[0], keyRotationStatus[1]);
const cache = createCache([listKeys], describeKey[3], keyPolicy[0], keyRotationStatus[1]);
kmsKeyRotation.run(cache, {}, (err, results) => {
expect(results.length).to.equal(1);
expect(results[0].status).to.equal(0);
Expand Down