Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ISSUE #4 #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

feromes
Copy link

@feromes feromes commented Jun 15, 2022

Trying to fix my mass in last PR :)

Now just update one file

@feromes feromes mentioned this pull request Jun 15, 2022
Copy link
Owner

@arademaker arademaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments. I believe the changes do not address the changes in the Lattes Specification.

@@ -55,11 +57,11 @@ Mountain View, California, 94041, USA.
<xsl:template match="TRABALHO-EM-EVENTOS">
<mods:mods ID="publication-{@SEQUENCIA-PRODUCAO}">
<mods:titleInfo>
<mods:title> <xsl:value-of select="DADOS-BASICOS-DO-TRABALHO/@TITULO-DO-TRABALHO" /> </mods:title>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change it? In my CV, the tag DADOS-BASICOS-DO-TRABALHO is the child of TRABALHOS-EM-EVENTOS. The XSD confirms that.

</mods:titleInfo>

<mods:originInfo>
<mods:dateIssued> <xsl:value-of select="DADOS-BASICOS-DO-TRABALHO/@ANO-DO-TRABALHO" /> </mods:dateIssued>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same case.

@@ -95,9 +97,9 @@ Mountain View, California, 94041, USA.
<xsl:apply-templates select="DETALHAMENTO-DO-TRABALHO/@ISBN"/>
</mods:relatedItem>

<xsl:apply-templates select="DADOS-BASICOS-DO-TRABALHO/@IDIOMA"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem

@@ -543,7 +550,9 @@ Mountain View, California, 94041, USA.

<xsl:template match="@DOI">
<xsl:if test="normalize-space(.) != ''">
<mods:identifier type="doi"><xsl:value-of select="."/></mods:identifier>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us try to avoid changes that are meaningless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants