Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting: Make early execution configurable #886

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

facuspagnuolo
Copy link
Contributor

@facuspagnuolo facuspagnuolo commented Jun 7, 2019

Related to aragon/client#590

This PR aims to turn the fact that votes can be early executed once they have already been decided, into a configurable option.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 97.105% when pulling 757cfed on early_execution_config into 98c30e9 on voting_delegation_app.

@aragon aragon deleted a comment from coveralls Jun 10, 2019
Copy link
Contributor

@bingen bingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
I guess changing the parameter could be confusing for users, specially for ongoing votes, so maybe we should ask for the preference during onboarding and maybe burn this new permission by default.
The way I see it, if an org wants to combine votes with early execution and without, they should have 2 separate instances, the same way we do now for different quorums.
I even wonder if it should be better to set this at init time only and remove the setter and the permission.

@facuspagnuolo facuspagnuolo force-pushed the voting_delegation_app branch from 165ebec to 7a39f6a Compare July 3, 2019 22:32
@facuspagnuolo facuspagnuolo force-pushed the early_execution_config branch from e674855 to 995dd6b Compare July 3, 2019 22:47
@luisivan
Copy link
Contributor

luisivan commented Jul 9, 2019

Included this for 0.9, the next release that will introduce smart contract changes. Thanks @facuspagnuolo!

Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the comment on the overrule window, what do you think about storing this as part of each vote?

It seems a bit weird that an existing vote can have its early execution behaviour change from underneath it. It causes a rather awkward (and error-prone) UX where you'd want to wait until any sensitive open votes are closed before executing a change to this parameter, rather than doing it whenever you wanted.

It starts to get a bit costly, but both the overrule window and the early execution variables can take up one slot in the Vote struct since they're being introduced together.

@facuspagnuolo
Copy link
Contributor Author

@sohkai thanks for the review! Already addressed your comments, please LMKYT!

@facuspagnuolo facuspagnuolo changed the base branch from voting_delegation_app to next July 19, 2019 02:29
@facuspagnuolo facuspagnuolo force-pushed the early_execution_config branch from 27da447 to ac8dfe0 Compare July 19, 2019 02:38
@facuspagnuolo facuspagnuolo merged commit 4721046 into next Jul 19, 2019
@facuspagnuolo facuspagnuolo deleted the early_execution_config branch July 19, 2019 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants