New Solana API #210
Open
New Solana API #210
+5,916
−5,513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-authsdk-ref-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authsdk-ref-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/solana.ts
Outdated
Comment on lines
10
to
12
| case 'signMessage': { | ||
| return bs58.decode(<string>response) | ||
| } |
There was a problem hiding this comment.
@mmjee response of this will be of the format
type SignatureRes = {
publicKey: BN // can use new solanaWeb3.PublicKey(address),
signature: Base58Decoded
}
src/solana.ts
Outdated
| return (await this.p.request({ | ||
| method: 'signMessage', | ||
| params: { | ||
| message: data, |
There was a problem hiding this comment.
@mmjee message will be TextEncoded format
{
message: new TextEncoder().encode(message)
}And then auth SDK will need to bs58 encode it
* intial code for esm build * Little adjustment --------- Co-authored-by: mmjee <[email protected]>
mmjee
force-pushed
the
mmjee/solana-api
branch
from
93855c9 to
b265f10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
Describe your changes
See ticket. WIP implementation of a new API for Solana consumers to maintain parity with well-known wallets. Will attempt to make it behave identically to others.
Issue ticket number and link
Checklist before requesting a review