Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile #104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Dockerfile #104

wants to merge 1 commit into from

Conversation

felixb
Copy link

@felixb felixb commented Mar 8, 2019

Add a Dockerfile for using dynalite w/o nodejs.

Unlike #64, this builds from source allowing integration with docker hub by using automated builds.
This would result in having docker hub building and hosting a docker images for each tag and the current latest master/HEAD on each push.

Running dynalite in docker would look like this:

docker run --rm -p 4567:4567 dynalite

Like the real dynalite executable parameters are available:

docker run --rm -p 8123:8123 dynalite --port 8123

Add a Dockerfile for using dynalite w/o nodejs.
@ryanblock
Copy link
Member

I'd be amenable to this, may need a few tweaks though. It's not clear from that Dockerfile how ports are configurable there (although to be honest, I'm no Docker expert). Would def want to see some tests too, and probably something around publishing to Docker Hub (which should be easy enough with GitHub Actions). wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants