Fix: handling useImplementingTypes and defaultNullableToNull #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardeois
approved these changes
Feb 3, 2025
Owner
ardeois
left a comment
ardeois
left a comment
There was a problem hiding this comment.
Looks good thanks !
Can you add a unit test for this please?
Contributor
Author
|
Thank you for acting promptly! I've added relevant test case that is failing on the latest version and works fine on this branch. |
Contributor
Author
|
Hi @ardeois. Is there anything I can do to help you with merging this branch? I don't want to be pushy but it would be great if we didn't have to maintain our own fork for this :) |
Owner
Sorry about that I missed the notification, I'll merge it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ardeois , thank you for the great package!
When
useImplementingTypesanddefaultNullableToNullare used at the same time, the plugin outputs weird|| || || ||in generated fixtures. This PR fixes this problem.