Skip to content

Fix type errors in generated code for nested input objects with @oneOf directive #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 13, 2025
Merged

Fix type errors in generated code for nested input objects with @oneOf directive #194

merged 4 commits into from
Aug 13, 2025

Conversation

@hedgepigdaniel
Copy link
Contributor

@hedgepigdaniel hedgepigdaniel commented Aug 8, 2025

Fixes #193

Skip terminateCircularRelationships logic for fields who's types are input objects with the @oneOf directive. This fixes the generation of incorrect code with type errors.

ardeois
ardeois approved these changes Aug 13, 2025
View reviewed changes
Copy link
Owner

@ardeois ardeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix !

@ardeois ardeois added the patch Increment the patch version when merged label Aug 13, 2025
@ardeois ardeois merged commit ac22426 into ardeois:main Aug 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ardeois ardeois ardeois approved these changes

Assignees

@hedgepigdaniel hedgepigdaniel

@ardeois ardeois

Labels

patch Increment the patch version when merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type errors in generated code when nested input objects have oneOf directive

2 participants

@hedgepigdaniel @ardeois