Skip to content

Conversation

dfuchss
Copy link
Member

@dfuchss dfuchss commented Aug 6, 2025

kotlinx-cli is deprecated / not maintained; this PR tries to replace it with picocli .. however we should test the new CLI

@dfuchss dfuchss requested review from Copilot and tobhey August 6, 2025 10:35
Copilot

This comment was marked as outdated.

@dfuchss dfuchss requested a review from Copilot August 6, 2025 10:44
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the CLI from the deprecated kotlinx-cli library to picocli, a modern Java/Kotlin command-line parsing framework. The migration involves restructuring command definitions, changing the CLI architecture, and updating build configuration.

  • Replace kotlinx-cli with picocli for command-line argument parsing
  • Convert commands from Subcommand inheritance to Callable interface implementation
  • Refactor output file handling to be command-specific rather than globally shared

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
RankCommand.kt Convert from Subcommand to picocli Command with Callable interface
ClassificationCommand.kt Migrate to picocli annotations and return exit codes
AggregationRankCommand.kt Update to use picocli Command structure
AggregationClassificationCommand.kt Convert to picocli-based command implementation
App.kt Replace ArgParser with CommandLine and add root command class
pom.xml Remove kotlinx-cli dependency and add picocli with annotation processing
Comments suppressed due to low confidence (1)

cli/pom.xml:15

  • PicoCLI version 4.7.7 does not exist. The latest version in the 4.x series is 4.7.6, released in September 2023. Consider using version 4.7.6 instead.
    <picocli.version>4.7.7</picocli.version>

Copy link

sonarqubecloud bot commented Aug 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant