-
Notifications
You must be signed in to change notification settings - Fork 0
Replace kotlinx-cli with picocli #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the CLI from the deprecated kotlinx-cli library to picocli, a modern Java/Kotlin command-line parsing framework. The migration involves restructuring command definitions, changing the CLI architecture, and updating build configuration.
- Replace kotlinx-cli with picocli for command-line argument parsing
- Convert commands from Subcommand inheritance to Callable interface implementation
- Refactor output file handling to be command-specific rather than globally shared
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
RankCommand.kt | Convert from Subcommand to picocli Command with Callable interface |
ClassificationCommand.kt | Migrate to picocli annotations and return exit codes |
AggregationRankCommand.kt | Update to use picocli Command structure |
AggregationClassificationCommand.kt | Convert to picocli-based command implementation |
App.kt | Replace ArgParser with CommandLine and add root command class |
pom.xml | Remove kotlinx-cli dependency and add picocli with annotation processing |
Comments suppressed due to low confidence (1)
cli/pom.xml:15
- PicoCLI version 4.7.7 does not exist. The latest version in the 4.x series is 4.7.6, released in September 2023. Consider using version 4.7.6 instead.
<picocli.version>4.7.7</picocli.version>
cli/src/main/kotlin/edu/kit/kastel/mcse/ardoco/metrics/cli/commands/RankCommand.kt
Outdated
Show resolved
Hide resolved
cli/src/main/kotlin/edu/kit/kastel/mcse/ardoco/metrics/cli/commands/RankCommand.kt
Outdated
Show resolved
Hide resolved
…mands/RankCommand.kt Co-authored-by: Copilot <[email protected]>
…mands/RankCommand.kt Co-authored-by: Copilot <[email protected]>
|
kotlinx-cli is deprecated / not maintained; this PR tries to replace it with picocli .. however we should test the new CLI