Utils offload #527

andreagilardoni · 2025-01-30T15:15:58Z

This PR depends on the release of Arduino_CloudUtils and the following PR arduino-libraries/Arduino_CloudUtils#17

mbed-core f7ff4114bc0d89f23b45423e049f5bc17114dcbc
renesas core 84d44b8f42bb657d66aa8fdda66f789f294dfddd
wifi bridge version 0.5.2
samd core 993398cb7a23a4e0f821a73501ae98053773165b
Current WiFi Firmware: 2.0.0

Board Name	connected	OTA
arduino:esp32:nano_nora	OK	OK
arduino:mbed_edge:edge_control	OK	NA
arduino:mbed_giga:giga	OK	OK
arduino:mbed_nano:nanorp2040connect	OK	OK
arduino:mbed_nicla:nicla_vision	OK	OK
arduino:mbed_opta:opta	OK (WIFI)	OK
arduino:mbed_portenta:envie_m7	OK (WIFI)	OK
arduino:renesas_portenta:portenta_c33	OK	NA
arduino:renesas_uno:unor4wifi	OK	OK
arduino:samd:mkr1000
arduino:samd:mkrgsm1400	OK	NA
arduino:samd:mkrnb1500	OK	NA
arduino:samd:mkrwan1300	OK	NA
arduino:samd:mkrwifi1010	OK	OK
arduino:samd:nano_33_iot	OK	OK
esp32:esp32:esp32	OK	OK
esp8266:esp8266:huzzah	OK	NA
rp2040:rp2040:rpipico	OK	NA

elf_diff_report.html.zip

codecov · 2025-02-06T13:31:19Z

Codecov Report

Attention: Patch coverage is 92.75362% with 10 lines in your changes missing coverage. Please review.

Project coverage is 94.81%. Comparing base (82c41d8) to head (caa60cd).
Report is 17 commits behind head on master.

Files with missing lines	Patch %	Lines
src/cbor/IoTCloudMessageEncoder.cpp	88.88%	6 Missing ⚠️
src/cbor/IoTCloudMessageDecoder.cpp	93.54%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
- Coverage   95.39%   94.81%   -0.59%     
==========================================
  Files          33       31       -2     
  Lines        1521     1370     -151     
==========================================
- Hits         1451     1299     -152     
- Misses         70       71       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

src/cbor/IoTCloudMessageDecoder.cpp

src/cbor/IoTCloudMessageEncoder.cpp

github-actions · 2025-04-02T14:52:49Z

Memory usage change @ caa60cd

Board	flash	%	RAM for global variables	%
`arduino:esp32:nano_nora`	🔺 +1460 - +2196	+0.05 - +0.07	🔺 +340 - +348	+0.1 - +0.11
`arduino:mbed_edge:edge_control`	🔺 +1680 - +1752	+0.17 - +0.18	🔺 +312 - +312	+0.12 - +0.12
`arduino:mbed_giga:giga`	🔺 0 - +2768	0.0 - +0.14	🔺 0 - +328	0.0 - +0.06
`arduino:mbed_nano:nanorp2040connect`	🔺 0 - +2690	0.0 - +0.02	🔺 0 - +312	0.0 - +0.12
`arduino:mbed_nicla:nicla_vision`	🔺 0 - +1744	0.0 - +0.09	🔺 0 - +328	0.0 - +0.06
`arduino:mbed_opta:opta`	🔺 0 - +2768	0.0 - +0.14	🔺 0 - +328	0.0 - +0.06
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	🔺 0 - +1552	0.0 - +0.07	🔺 0 - +336	0.0 - +0.06
`arduino:renesas_uno:unor4wifi`	🔺 +1096 - +1552	+0.42 - +0.59	🔺 +312 - +312	+0.95 - +0.95
`arduino:samd:mkr1000`	🔺 0 - +1672	0.0 - +0.64	🔺 0 - +320	0.0 - +0.98
`arduino:samd:mkrgsm1400`	🔺 0 - +1664	0.0 - +0.63	🔺 0 - +320	0.0 - +0.98
`arduino:samd:mkrnb1500`	🔺 0 - +1664	0.0 - +0.63	🔺 0 - +320	0.0 - +0.98
`arduino:samd:mkrwan1300`	🔺 +1656 - +3160	+0.63 - +1.21	🔺 +304 - +320	+0.93 - +0.98
`arduino:samd:mkrwifi1010`	🔺 0 - +1656	0.0 - +0.63	🔺 0 - +320	0.0 - +0.98
`arduino:samd:nano_33_iot`	🔺 0 - +1648	0.0 - +0.63	🔺 0 - +312	0.0 - +0.95
`esp32:esp32:esp32`	🔺 +1104 - +1812	+0.08 - +0.14	🔺 +344 - +360	+0.1 - +0.11
`esp8266:esp8266:huzzah`	🔺 +1748 - +1768	+0.17 - +0.17	🔺 +332 - +352	+0.41 - +0.43
`rp2040:rp2040:rpipicow`	🔺 +1744 - +1744	+0.08 - +0.08	🔺 +440 - +448	+0.17 - +0.17

Click for full report table

Board	`examples/ArduinoIoTCloud-Advanced` flash	%	`examples/ArduinoIoTCloud-Advanced` RAM for global variables	%	`examples/ArduinoIoTCloud-Basic` flash	%	`examples/ArduinoIoTCloud-Basic` RAM for global variables	%	`examples/ArduinoIoTCloud-Callbacks` flash	%	`examples/ArduinoIoTCloud-Callbacks` RAM for global variables	%	`examples/utility/ArduinoIoTCloud_Travis_CI` flash	%	`examples/utility/ArduinoIoTCloud_Travis_CI` RAM for global variables	%	`examples/ArduinoIoTCloud-DeferredOTA` flash	%	`examples/ArduinoIoTCloud-DeferredOTA` RAM for global variables	%	`examples/ArduinoIoTCloud-Notecard` flash	%	`examples/ArduinoIoTCloud-Notecard` RAM for global variables	%	`examples/ArduinoIoTCloud-Schedule` flash	%	`examples/ArduinoIoTCloud-Schedule` RAM for global variables	%	`examples/utility/Provisioning` flash	%	`examples/utility/Provisioning` RAM for global variables	%	`examples/utility/SelfProvisioning` flash	%	`examples/utility/SelfProvisioning` RAM for global variables	%
`arduino:esp32:nano_nora`	1460	0.05	340	0.1	1492	0.05	340	0.1	1480	0.05	340	0.1	1460	0.05	340	0.1	1476	0.05	340	0.1	2196	0.07	348	0.11	1468	0.05	340	0.1
`arduino:mbed_edge:edge_control`	1744	0.18	312	0.12	1680	0.17	312	0.12	1688	0.17	312	0.12	1744	0.18	312	0.12					1744	0.18	312	0.12	1752	0.18	312	0.12
`arduino:mbed_giga:giga`	2768	0.14	328	0.06	2768	0.14	296	0.06	2768	0.14	328	0.06	2704	0.14	296	0.06	2768	0.14	328	0.06	1744	0.09	312	0.06	2768	0.14	296	0.06	0	0.0	0	0.0
`arduino:mbed_nano:nanorp2040connect`	2689	0.02	312	0.12	2690	0.02	312	0.12	2690	0.02	312	0.12	2689	0.02	312	0.12	2690	0.02	312	0.12	1704	0.01	312	0.12	2690	0.02	312	0.12	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_nicla:nicla_vision`	1168	0.06	296	0.06	1176	0.06	328	0.06	1232	0.06	296	0.06	1176	0.06	328	0.06	1232	0.06	296	0.06	1744	0.09	312	0.06	1240	0.06	328	0.06	0	0.0	0	0.0
`arduino:mbed_opta:opta`	2768	0.14	296	0.06	2768	0.14	296	0.06	2768	0.14	296	0.06	2704	0.14	328	0.06	2768	0.14	328	0.06	1744	0.09	312	0.06	2768	0.14	328	0.06	0	0.0	0	0.0
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	1544	0.07	336	0.06	1544	0.07	336	0.06	1552	0.07	336	0.06	1544	0.07	304	0.06					1552	0.07	312	0.06	1544	0.07	304	0.06	0	0.0	0	0.0
`arduino:renesas_uno:unor4wifi`	1096	0.42	312	0.95	1096	0.42	312	0.95	1096	0.42	312	0.95	1112	0.42	312	0.95					1552	0.59	312	0.95	1096	0.42	312	0.95
`arduino:samd:mkr1000`	1656	0.63	304	0.93	1648	0.63	304	0.93	1672	0.64	320	0.98	1672	0.64	320	0.98					1664	0.63	320	0.98	1672	0.64	320	0.98	0	0.0	0	0.0
`arduino:samd:mkrgsm1400`	1664	0.63	320	0.98	1656	0.63	304	0.93	1648	0.63	304	0.93	1656	0.63	304	0.93					1656	0.63	320	0.98	1656	0.63	304	0.93	0	0.0	0	0.0
`arduino:samd:mkrnb1500`	1664	0.63	320	0.98	1656	0.63	304	0.93	1648	0.63	304	0.93	1656	0.63	304	0.93					1656	0.63	320	0.98	1656	0.63	304	0.93	0	0.0	0	0.0
`arduino:samd:mkrwan1300`	3024	1.15	320	0.98	3032	1.16	320	0.98	3160	1.21	304	0.93	3016	1.15	304	0.93					1656	0.63	320	0.98
`arduino:samd:mkrwifi1010`	880	0.34	304	0.93	896	0.34	320	0.98	896	0.34	320	0.98	896	0.34	320	0.98	896	0.34	320	0.98	1656	0.63	320	0.98	896	0.34	320	0.98	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:nano_33_iot`	888	0.34	312	0.95	888	0.34	312	0.95	888	0.34	312	0.95	888	0.34	312	0.95	888	0.34	312	0.95	1648	0.63	312	0.95	888	0.34	312	0.95	0	0.0	0	0.0	0	0.0	0	0.0
`esp32:esp32:esp32`	1104	0.08	352	0.11	1104	0.08	344	0.1	1104	0.08	352	0.11	1144	0.09	344	0.1	1116	0.09	344	0.1	1812	0.14	360	0.11	1124	0.09	352	0.11
`esp8266:esp8266:huzzah`	1768	0.17	348	0.42	1748	0.17	336	0.41	1748	0.17	352	0.43	1752	0.17	332	0.41									1752	0.17	332	0.41
`rp2040:rp2040:rpipicow`	1744	0.08	448	0.17	1744	0.08	440	0.17	1744	0.08	440	0.17	1744	0.08	440	0.17

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/ArduinoIoTCloud-Callbacks<br>flash,%,examples/ArduinoIoTCloud-Callbacks<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/ArduinoIoTCloud-DeferredOTA<br>flash,%,examples/ArduinoIoTCloud-DeferredOTA<br>RAM for global variables,%,examples/ArduinoIoTCloud-Notecard<br>flash,%,examples/ArduinoIoTCloud-Notecard<br>RAM for global variables,%,examples/ArduinoIoTCloud-Schedule<br>flash,%,examples/ArduinoIoTCloud-Schedule<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:esp32:nano_nora,1460,0.05,340,0.1,1492,0.05,340,0.1,1480,0.05,340,0.1,1460,0.05,340,0.1,1476,0.05,340,0.1,2196,0.07,348,0.11,1468,0.05,340,0.1
arduino:mbed_edge:edge_control,1744,0.18,312,0.12,1680,0.17,312,0.12,1688,0.17,312,0.12,1744,0.18,312,0.12,,,,,1744,0.18,312,0.12,1752,0.18,312,0.12
arduino:mbed_giga:giga,2768,0.14,328,0.06,2768,0.14,296,0.06,2768,0.14,328,0.06,2704,0.14,296,0.06,2768,0.14,328,0.06,1744,0.09,312,0.06,2768,0.14,296,0.06,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,2689,0.02,312,0.12,2690,0.02,312,0.12,2690,0.02,312,0.12,2689,0.02,312,0.12,2690,0.02,312,0.12,1704,0.01,312,0.12,2690,0.02,312,0.12,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,1168,0.06,296,0.06,1176,0.06,328,0.06,1232,0.06,296,0.06,1176,0.06,328,0.06,1232,0.06,296,0.06,1744,0.09,312,0.06,1240,0.06,328,0.06,0,0.0,0,0.0,,,,
arduino:mbed_opta:opta,2768,0.14,296,0.06,2768,0.14,296,0.06,2768,0.14,296,0.06,2704,0.14,328,0.06,2768,0.14,328,0.06,1744,0.09,312,0.06,2768,0.14,328,0.06,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,
arduino:renesas_portenta:portenta_c33,1544,0.07,336,0.06,1544,0.07,336,0.06,1552,0.07,336,0.06,1544,0.07,304,0.06,,,,,1552,0.07,312,0.06,1544,0.07,304,0.06,0,0.0,0,0.0,,,,
arduino:renesas_uno:unor4wifi,1096,0.42,312,0.95,1096,0.42,312,0.95,1096,0.42,312,0.95,1112,0.42,312,0.95,,,,,1552,0.59,312,0.95,1096,0.42,312,0.95,,,,,,,,
arduino:samd:mkr1000,1656,0.63,304,0.93,1648,0.63,304,0.93,1672,0.64,320,0.98,1672,0.64,320,0.98,,,,,1664,0.63,320,0.98,1672,0.64,320,0.98,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,1664,0.63,320,0.98,1656,0.63,304,0.93,1648,0.63,304,0.93,1656,0.63,304,0.93,,,,,1656,0.63,320,0.98,1656,0.63,304,0.93,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,1664,0.63,320,0.98,1656,0.63,304,0.93,1648,0.63,304,0.93,1656,0.63,304,0.93,,,,,1656,0.63,320,0.98,1656,0.63,304,0.93,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,3024,1.15,320,0.98,3032,1.16,320,0.98,3160,1.21,304,0.93,3016,1.15,304,0.93,,,,,1656,0.63,320,0.98,,,,,,,,,,,,
arduino:samd:mkrwifi1010,880,0.34,304,0.93,896,0.34,320,0.98,896,0.34,320,0.98,896,0.34,320,0.98,896,0.34,320,0.98,1656,0.63,320,0.98,896,0.34,320,0.98,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,888,0.34,312,0.95,888,0.34,312,0.95,888,0.34,312,0.95,888,0.34,312,0.95,888,0.34,312,0.95,1648,0.63,312,0.95,888,0.34,312,0.95,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,1104,0.08,352,0.11,1104,0.08,344,0.1,1104,0.08,352,0.11,1144,0.09,344,0.1,1116,0.09,344,0.1,1812,0.14,360,0.11,1124,0.09,352,0.11,,,,,,,,
esp8266:esp8266:huzzah,1768,0.17,348,0.42,1748,0.17,336,0.41,1748,0.17,352,0.43,1752,0.17,332,0.41,,,,,,,,,1752,0.17,332,0.41,,,,,,,,
rp2040:rp2040:rpipicow,1744,0.08,448,0.17,1744,0.08,440,0.17,1744,0.08,440,0.17,1744,0.08,440,0.17,,,,,,,,,,,,,,,,,,,,

per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 30, 2025

andreagilardoni force-pushed the utils-offload-master-rebased branch from dd39de0 to fc909c0 Compare February 5, 2025 10:09

This comment was marked as outdated.

Sign in to view

andreagilardoni force-pushed the utils-offload-master-rebased branch from 6872c74 to fbfae95 Compare February 6, 2025 12:43

This comment was marked as outdated.

Sign in to view

andreagilardoni mentioned this pull request Feb 10, 2025

Use Arduino_CloudUtils #518

Closed

andreagilardoni force-pushed the utils-offload-master-rebased branch from 84621c0 to e60ea69 Compare February 10, 2025 12:55

This comment was marked as outdated.

Sign in to view

andreagilardoni force-pushed the utils-offload-master-rebased branch from e778f3a to 8bb5f4a Compare February 25, 2025 12:17

This comment was marked as outdated.

Sign in to view

andreagilardoni force-pushed the utils-offload-master-rebased branch 3 times, most recently from 3339e5b to 34b7bc9 Compare March 10, 2025 09:54

andreagilardoni marked this pull request as ready for review March 10, 2025 13:04

andreagilardoni requested a review from pennam March 10, 2025 13:04

This comment was marked as outdated.

Sign in to view

andreagilardoni force-pushed the utils-offload-master-rebased branch from 734f7a2 to e9edccd Compare March 11, 2025 14:35

This comment was marked as outdated.

Sign in to view

andreagilardoni force-pushed the utils-offload-master-rebased branch from 67e3c33 to b6e302b Compare March 18, 2025 10:40

andreagilardoni force-pushed the utils-offload-master-rebased branch from b6e302b to 8c3e99a Compare April 2, 2025 13:00

pennam reviewed Apr 2, 2025

View reviewed changes

src/cbor/IoTCloudMessageDecoder.cpp Outdated Show resolved Hide resolved

pennam reviewed Apr 2, 2025

View reviewed changes

src/cbor/IoTCloudMessageEncoder.cpp Outdated Show resolved Hide resolved

pennam reviewed Apr 2, 2025

View reviewed changes

src/cbor/IoTCloudMessageEncoder.cpp Outdated Show resolved Hide resolved

andreagilardoni and others added 6 commits April 2, 2025 15:22

added CMake into gitignore

03d1d62

Use Arduino_CloudUtils

697cd61

offload tinycbor to CloudUtils

2894f37

moving encoder/decoder interfaces into cloudUtils library

7172d53

restructuring CBOR.h for cloud utils offload

2455317

splitting Commands definition for utils offload

a619b12

This comment was marked as outdated.

Sign in to view

andreagilardoni force-pushed the utils-offload-master-rebased branch 2 times, most recently from 18911a6 to d06031e Compare April 2, 2025 13:52

implementing cbor message encoder following cloud utils definition

7c048bf

andreagilardoni force-pushed the utils-offload-master-rebased branch from d06031e to a79607b Compare April 2, 2025 14:08

andreagilardoni and others added 9 commits April 2, 2025 16:26

implementing cbor message decoder following cloud utils definition

78507df

Adapted name change of Message decoder for ArduinoIoTCloud subclasses

7e6f473

Including Arduino_CloudUtils in cmake unit testing

ca81751

Adapting ArduinoIotCloud to Cloud utils new encode/decode

36bcb92

Including Arduino_CoudUtils in CI for compile examples

56afa6b

improving test coverage for cbor encode

6190d72

utility: remove TimedAttemp

85d49db

improving decode unit testing by means of REQUIRE_THAT

f594fa2

Unit testing adding missing test cases for failing decode

caa60cd

andreagilardoni force-pushed the utils-offload-master-rebased branch from a79607b to caa60cd Compare April 2, 2025 14:26

pennam merged commit 4bc2784 into arduino-libraries:master Apr 3, 2025
22 of 24 checks passed

Utils offload #527

Utils offload #527

Uh oh!

Conversation

andreagilardoni commented Jan 30, 2025 • edited by pennam Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

codecov bot commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

github-actions bot commented Apr 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andreagilardoni commented Jan 30, 2025 •

edited by pennam

Loading

codecov bot commented Feb 6, 2025 •

edited

Loading