Move AVR Wire library utility folder under src

[sandeepmistry]

Resolves #4653.

[ArduinoBot]

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4655-BUILD-518-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4655-BUILD-518-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4655-BUILD-518-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4655-BUILD-518-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4655-BUILD-518-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

[jpl-pfungst]

Hello,

I have downloaded the file for Windows, I have unpack the zip file,
replace the original arduino library
restarted the test and get the same error.

in the source file
#include <stdio.h>
#include <VirtualWire.h>
#include <Servo.h>

having only one include works with both it does not.

Thanks for your help

<--------------------------------------------------------------------------------------------------
Arduino: 1.6.8 (Windows 10), Board: "Arduino/Genuino Uno"

libraries\Servo\avr\Servo.cpp.o: In function `__vector_11':

C:\Program Files (x86)\Arduino\libraries\Servo\src\avr/Servo.cpp:81:
multiple definition of `__vector_11'

libraries\VirtualWire\VirtualWire.cpp.o:C:\Program Files
(x86)\Arduino\libraries\VirtualWire/VirtualWire.cpp:591: first defined here

collect2.exe: error: ld returned 1 exit status

exit status 1
Fehler beim Kompilieren.

This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.

---

Am 04.03.2016 um 23:31 schrieb Arduino Bot:
✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4655-BUILD-518-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4655-BUILD-518-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4655-BUILD-518-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4655-BUILD-518-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4655-BUILD-518-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

---

Reply to this email directly or view it on GitHub:
#4655 (comment)

Jean-Pierre Lauqué
Zwingenbergerstr. 9
D64319 Pfungstadt
[email protected]
Fix 00496157990844
Mob 0049170 4852635

[jpl-pfungst]

what do you mean ?
What is the AVR wire library?
what the full path ?
I got : arduino\hardware\arduino\avr
\bootloaders
\cores
\frimwares
\libraries
...
\Wire
\examples
\src
\utility
twi.c
twi.h
wire.cpp
wire.h

\variants

what do I have to move where?

[sandeepmistry]

@jpl-pfungst please see @PaulStoffregen's comment in #4654 (comment).

The goal of this patch is to resolve issue #4653, that occurs with the hourly build.

[MauroMombelli]

this patch is fine, but the motivation it is needed are scary; all libraries using "utility" folder (pre-1.6) which is seen as flat, will NOT work now.

[matthijskooijman]

@MauroMombelli, I'm not sure I see your point here? The flat type of libraries, as was the default in 1.0, do not have any src folder, just source files in the root and optionally in a utility folder. Those libraries should work just as they did before. The problem with the Wire library, AFAICS, is that it was converted from a flat to recursive style library incorrectly: The source files from the root were moved into the src/ folder, but not the utility folder, so the resulting library didn't work under any Arduino version. Or am I missing your point here?

[MauroMombelli]

no you are right, i missed the src