Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for MLPackages and constituent .mlmodel protobufs for associated models #193

Merged
merged 4 commits into from
Aug 10, 2024

Conversation

bpkeene
Copy link
Contributor

@bpkeene bpkeene commented Aug 7, 2024

If MLPackage/...../model.mlmodel is found, and there is no associated mlmodelc present, use the mlpackage protobuf.

-- Does not modify model loading in OS WK.  This is a hook to modify
load path URLs.
@bpkeene bpkeene force-pushed the user/bkeene/mlpackage_loading branch from 2d2658a to 5c8662a Compare August 7, 2024 18:36
@bpkeene
Copy link
Contributor Author

bpkeene commented Aug 7, 2024

Also includes timing for [encoder, decoder] loading

computeUnits: modelCompute.prefillCompute,
if let audioEncoder = audioEncoder as? WhisperMLModel {
Logging.debug("Loading audio encoder")
let encoderLoadStart = modelLoadStart // CFAbsoluteTimeGetCurrent()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about this part, is CFAbsoluteTimeGetCurrent() having some accuracy issue?

Copy link
Contributor

@ZachNagengast ZachNagengast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 👍

@ZachNagengast ZachNagengast merged commit 1f40552 into main Aug 10, 2024
15 checks passed
@bpkeene bpkeene deleted the user/bkeene/mlpackage_loading branch February 6, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants