Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress for vad #223

Merged
merged 1 commit into from
Oct 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Sources/WhisperKit/Core/WhisperKit.swift
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,8 @@ open class WhisperKit {
decodeOptions: decodeOptions
)

progress.totalUnitCount = max(progress.totalUnitCount, Int64(audioChunks.count))

// Reset the seek times since we've already chunked the audio
var chunkedOptions = decodeOptions
chunkedOptions?.clipTimestamps = []
Expand Down Expand Up @@ -844,7 +846,8 @@ open class WhisperKit {
try Task.checkCancellation()

let childProgress = Progress()
progress.totalUnitCount += 1
// Total can be set elsewhere, here ensures it is at least 1
progress.totalUnitCount = max(1, progress.totalUnitCount)
progress.addChild(childProgress, withPendingUnitCount: 1)

let transcribeTask = TranscribeTask(
Expand Down