Improve SegmentSeeker word alignment #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Wooster <[email protected]>
- This will allow wrapper to handle newer versions of the tokenizer protocol without requiring strict conformance
a2they
approved these changes
Feb 21, 2025
| } | ||
|
|
||
| public init( | ||
| id: Int = 0, |
There was a problem hiding this comment.
since we set defaults here, we should remove redundancy above
| return updatedSegments | ||
| } | ||
|
|
||
| public func calculateWordDurationConstraints(alignment: [WordTiming]) -> (Float, Float) { |
There was a problem hiding this comment.
let's add names to Floats in the return tuple, i.e. (median: Float, max: Float)
| let end = (timeOffset + timing.end).rounded(2) | ||
|
|
||
| // Handle short duration words by moving their start time back if there's space | ||
| if end - start < constrainedMedianDuration / 4 { |
There was a problem hiding this comment.
nit: it would be nice to add example in comments for each of these if/else cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes primarily focus on enhancing the
SegmentSeekerclass to fix some edge cases and make it more testable. It also adds public initializers to various structs and uses more flexible dependency versioning to allow usage of newer versions of swift-transformers if desired.