fix: Unmanage app on agent on deletion event #301
+159
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
jannfis
requested review from
jgwest,
ishitasequeira and
chetan-rns
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 48.79% 49.65% +0.85%
==========================================
Files 73 73
Lines 6400 6404 +4
==========================================
+ Hits 3123 3180 +57
+ Misses 3017 2959 -58
- Partials 260 265 +5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: jannfis <[email protected]>
anandf
reviewed
Feb 13, 2025
| @@ -97,7 +97,9 @@ func (a *Agent) addAppDeletionToQueue(app *v1alpha1.Application) { | |||
| logCtx.Debugf("Delete app event") | |||
|
|
|||
| if !a.appManager.IsManaged(app.QualifiedName()) { | |||
| logCtx.Tracef("App is not managed") | |||
| logCtx.Tracef("App is not managed, proceeding anyways") | |||
There was a problem hiding this comment.
nitpick: logCtx.Trace can be used as there are no format specifiers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it:
When an app is deleted on the agent, it was not unmanaged. That prevented the agent from creating a new app with the same name again.
In addition, this PR adds unit tests for the agent's informer callbacks.
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer:
Checklist