fix(write-back): Duplicate image entries with different formats when updating two images #1037
+72
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengfang
requested review from
jannfis,
pasha-codefresh and
ishitasequeira
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1037 +/- ##
==========================================
+ Coverage 62.59% 62.89% +0.29%
==========================================
Files 15 15
Lines 2259 2269 +10
==========================================
+ Hits 1414 1427 +13
+ Misses 755 753 -2
+ Partials 90 89 -1 ☔ View full report in Codecov by Sentry. |
…updating two images Signed-off-by: Cheng Fang <[email protected]>
chengfang
force-pushed
the
duplicate.entries.in.write
branch
from
b6386e0 to
44f5996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1034
Modified
mergeKustomizeOverridemethod to have more control over setting and adding parameters to.argocd-source-*.yamltarget file.