fix: sort modal menu options alphabetically with prefix matches first #77
+60
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de into feat/sinister-quotes
- Add sortKey prop to useFilteredList for alphabetical sorting - Prefix matches are prioritized and sorted alphabetically - Non-prefix matches follow, also sorted alphabetically - Apply sortKey to slash command autocomplete in prompt-input
…omplete Replace fuzzysort-based autocomplete with deterministic alphabetical sorting that: - Tier 1: Commands starting with filter (prefix matches) - Tier 2: Commands containing filter in name (substring matches) - Tier 3: Commands matching only in description/aliases Each tier is sorted alphabetically, with up to 100 results total. Fixes unpredictable ordering where '/wrong-branch' appeared before '/auto-integrate-branches'.
Resolved conflict in autocomplete.tsx by keeping dev branch's fuzzysort implementation with frecency scoring over the simpler tieredMatch approach.
…de into feat/sinister-quotes
…ordering The tieredMatch implementation was accidentally reverted during a dev merge. This restores the original fix that ensures: - Tier 1: Commands starting with filter (prefix matches) - Tier 2: Commands containing filter in name (substring matches) - Tier 3: Commands matching only in description/aliases Each tier is sorted alphabetically for predictable ordering.
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
ariane-emory
force-pushed
the
fix/modal-menus-filtered-order
branch
from
6eb171b to
239fed6
Compare
ariane-emory
force-pushed
the
fix/modal-menus-filtered-order
branch
from
f5dc48d to
239fed6
Compare
Resolved conflict in autocomplete.tsx by preserving tieredMatch approach from this branch while accepting other changes from dev branch. Fixed syntax error from merge conflict resolution.
…-emory/opencode into fix/autocompletion-filtered-order
ariane-emory
force-pushed
the
fix/modal-menus-filtered-order
branch
2 times, most recently
from
f64b9ce to
646a87b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DUMMY PR, IGNORE.