Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): Refactor network_service vxlan_interfaces #4962

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jan 31, 2025

Change Summary

TODO:

Related Issue(s)

Fixes #

Component(s) name

arista.avd.<role-name>

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4962
# Activate the virtual environment
source test-avd-pr-4962/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@refactor/eos_designs/network-services/vxlan-interfaces#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/network-services/vxlan-interfaces --force
# Optional: Install AVD examples
cd test-avd-pr-4962
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Feb 3, 2025
@gmuloc gmuloc marked this pull request as ready for review February 3, 2025 13:50
@gmuloc gmuloc requested review from a team as code owners February 3, 2025 13:50
@gmuloc gmuloc requested review from ClausHolbechArista and a team February 4, 2025 14:20
@gmuloc gmuloc requested a review from a team February 6, 2025 13:43
@ClausHolbechArista ClausHolbechArista requested a review from a team February 6, 2025 15:49
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Feb 6, 2025
@gmuloc gmuloc added this to the v5.2.0 milestone Feb 7, 2025
Copy link

sonarqubecloud bot commented Feb 7, 2025

@ClausHolbechArista ClausHolbechArista merged commit 520ec21 into aristanetworks:devel Feb 7, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_designs) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants