Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: pre-commit autoupdate #4969

Merged
merged 2 commits into from
Feb 4, 2025
Merged

CI: pre-commit autoupdate #4969

merged 2 commits into from
Feb 4, 2025

Conversation

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.9.3 → v0.9.4](astral-sh/ruff-pre-commit@v0.9.3...v0.9.4)
- [github.com/pycqa/pylint: v3.3.3 → v3.3.4](pylint-dev/pylint@v3.3.3...v3.3.4)
- [github.com/codespell-project/codespell: v2.4.0 → v2.4.1](codespell-project/codespell@v2.4.0...v2.4.1)
@pre-commit-ci pre-commit-ci bot requested review from a team as code owners February 3, 2025 16:59
Copy link

github-actions bot commented Feb 3, 2025

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4969
# Activate the virtual environment
source test-avd-pr-4969/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/aristanetworks/avd.git@pre-commit-ci-update-config#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/aristanetworks/avd.git#/ansible_collections/arista/avd/,pre-commit-ci-update-config --force
# Optional: Install AVD examples
cd test-avd-pr-4969
ansible-playbook arista.avd.install_examples

@gmuloc
Copy link
Contributor

gmuloc commented Feb 4, 2025

readthedocs error when building the doc:

python -m mkdocs build --clean --site-dir $READTHEDOCS_OUTPUT/html --config-file mkdocs.yml
INFO    -  Cleaning site directory
INFO    -  Building documentation to directory: /home/docs/checkouts/readthedocs.org/user_builds/ansible-avd/checkouts/4969/_readthedocs/html
INFO    -  The following pages exist in the docs directory, but are not included in the "nav" configuration:
  - ansible_collections/arista/avd/examples/single-dc-l3ls/documentation/devices/dc1-leaf1a.md
  - ansible_collections/arista/avd/examples/single-dc-l3ls/documentation/fabric/FABRIC-documentation.md
ERROR   -  Error reading page 'docs/pyavd/pyavd.md':
ERROR   -  Invalid options: PythonOptions.__init__() got an unexpected keyword argument 'paths'

Aborted with a BuildError!

Copy link

sonarqubecloud bot commented Feb 4, 2025

@gmuloc
Copy link
Contributor

gmuloc commented Feb 4, 2025

Fixed with merge of devel - probably a fluke

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Feb 4, 2025
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit a2d2939 into devel Feb 4, 2025
44 checks passed
@carlbuchmann carlbuchmann deleted the pre-commit-ci-update-config branch February 4, 2025 21:12
@github-actions github-actions bot added the rn: CI label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants