fix(profiles): deploy on the normal release tags - #44
Merged
Conversation
Drop the separate profiles-v* tag namespace: the same v*.*.* tag that releases the desktop app now also deploys profiles, so one tag ships everything. workflow_dispatch stays for out-of-band fixes.
github-actions
Bot
added
size:S
vouch:trusted
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Prerelease tags (e.g., v0.6.0-beta.1) should not deploy to the live profiles worker. Added condition to skip tags containing hyphens, which matches the same prerelease detection logic used in the desktop release workflow.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Manual deploy job always skipped
- Updated job condition to allow workflow_dispatch events in addition to non-prerelease tag pushes, restoring the intended out-of-band deploy functionality.
You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 84c8e1f. Configure here.
The deploy job condition was blocking manual workflow_dispatch triggers because it required github.ref_type == 'tag', which is only true for tag pushes. Manual triggers from branches set ref_type to 'branch', causing the job to skip. Updated condition to allow both workflow_dispatch events and non-prerelease tag pushes (tags without hyphens).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #43: drops the separate
profiles-v*tag namespace. The samev*.*.*tag that releases the desktop app now also deploys profiles — one deliberate ship action for everything.workflow_dispatchstays for out-of-band deploys.Note
Low Risk
CI-only workflow trigger changes; no application runtime behavior.
Overview
Profiles now deploy on the same
v*.*.*tags as the desktop release, instead of a separateprofiles-v*tag namespace—one tag ships both.The deploy job adds a guard so only manual runs or non–pre-release tags (no
-in the tag name) trigger deploy;workflow_dispatchis unchanged for out-of-band fixes.Reviewed by Cursor Bugbot for commit 64acb03. Bugbot is set up for automated code reviews on this repo. Configure here.