Speedup c2a-dev-runtime with C2A_DEV_RUNTIME_SPEED env #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces dynamic runtime speed control for the c2a-dev-runtime through the C2A_DEV_RUNTIME_SPEED environment variable, allowing developers to adjust the simulation speed.
- Adds environment variable-based speed multiplier configuration
- Replaces fixed update interval with dynamically calculated duration
- Includes validation to ensure positive speed multiplier values
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+23
to
+24
| let base_millis = DEFAULT_UPDATE_BATCH_IN_REALTIME.as_millis() as f64; | ||
| let adjusted_millis = (base_millis / *SPEED_MULTIPLIER).max(1.0) as u64; |
There was a problem hiding this comment.
The SPEED_MULTIPLIER is dereferenced every time UPDATE_INTERVAL is accessed. Consider storing the calculated interval value directly in the LazyLock to avoid repeated division operations during runtime.
ToshiAki64
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
C2A_DEV_RUNTIME_SPEED環境変数を使って、c2a-dev-runtimeの動作速度を可変にする影響範囲
c2a-dev-runtime