Remove dead code, identity functions, and duplicated URL builders#263
Merged
Remove dead code, identity functions, and duplicated URL builders#263
Conversation
- Remove `konvoy-util/src/process.rs` — `run_command` and `CommandOutput` are never imported outside their own module; all callers use `std::process::Command` directly (-77 lines) - Remove `derive_dep_name()` identity function in update.rs — just returned its input; inline `.clone()` at the call site - Remove `split_maven_coordinate` wrapper in update.rs — dead indirection to `common::split_maven_coordinate` - Simplify `MavenCoordinate::cache_path` to delegate to `repository_path` instead of recomputing the same group/artifact/version path - Extract `maven_artifact_url()` in maven.rs — shared by `pom_url` and `module_metadata_url`, eliminating duplicated URL pattern Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process.rs—run_command/CommandOutputnever imported outside module; all callers usestd::process::Commanddirectly (-77 lines)derive_dep_name()— Identity function that just returned its input unchangedsplit_maven_coordinatewrapper in update.rs — one-line delegation tocommon::split_maven_coordinatecache_pathdelegates torepository_path— Eliminated duplicated group/artifact/version path computationmaven_artifact_url()helper — Shared bypom_urlandmodule_metadata_url, replacing duplicated URL pattern6 files changed, +15 -134 (net -119 lines)
Test plan
cargo test --workspace— 753/753 tests pass (7 fewer = removed dead code tests)cargo clippy --workspace -- -D warnings— 0 warningscargo fmt --all -- --check— clean🤖 Generated with Claude Code