Add 15 smoke tests: test command, lint execution, build flags, transitive deps#265
Merged
Add 15 smoke tests: test command, lint execution, build flags, transitive deps#265
Conversation
New smoke tests for previously uncovered I/O-bound code paths: Test command (test_build.rs): - test_test_lifecycle: compile tests, cache hit on second run - test_test_no_test_dir_fails: missing src/test/ error - test_test_filter: --filter flag forwarded to test binary Lint full execution (detekt.rs): - test_lint_detects_findings: actual detekt run on real code - test_lint_verbose: --verbose flag - test_lint_locked: lockfile hash persistence + --locked mode - test_lint_custom_config: --config flag with custom file - test_lint_missing_config_fails: nonexistent config error Build flags: - test_build_force_bypasses_cache: --force recompiles - test_build_verbose_shows_output: --verbose flag - test_locked_toolchain_mismatch_fails: lockfile version mismatch Init in-place: - test_init_in_place: init without --name - test_init_in_place_lib: init --lib without --name Transitive Maven deps: - test_update_transitive_deps_in_lockfile: atomicfu via coroutines, required_by tracking Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 15 new smoke tests covering I/O-bound code paths that can't be unit-tested. These exercise the real Kotlin/Native compiler, detekt JAR downloads, JRE bundling, and Maven dependency resolution inside the Docker-based smoke test environment.
New tests (15)
test_test_lifecycletest_test_no_test_dir_failssrc/test/error pathtest_test_filter--filterflag forwarded to test binarytest_lint_detects_findingstest_lint_verbose--verboseflagtest_lint_locked--lockedmodetest_lint_custom_config--configflag with custom detekt.ymltest_lint_missing_config_failstest_build_force_bypasses_cache--forcerecompiles despite cachetest_build_verbose_shows_output--verboseflagtest_locked_toolchain_mismatch_failstest_init_in_placekonvoy initwithout--nametest_init_in_place_libkonvoy init --libwithout--nametest_update_transitive_deps_in_lockfilerequired_bytrackingCoverage impact
These tests exercise the previously uncovered I/O paths in:
test_build.rs(was 17% → test compilation + cache + runner)detekt.rs(was 47% → JAR download, lint execution, output parsing, config handling)build.rs--force/--verbose/--lockedflag pathsupdate.rstransitive BFS resolution +required_bytrackingTotal smoke tests: 60 → 75
Test plan
bash -n tests/smoke/tests.sh)🤖 Generated with Claude Code