Conversation
Adds FIRESTORE_INTEGRATION_TEST_RESULTS.md documenting end-to-end tests against a live Firestore instance (33/33 passing). Includes: - Complete drag-and-drop FastAPI reference server - Required environment, Dockerfile, requirements.txt - Verified document schemas for drawers, triples, entities, tunnels Updates FIRESTORE_BACKEND.md with: - COLLECTION_GROUP scope requirement for composite indexes when triples live in subcollections (critical gotcha that causes runtime 500s if missed) - Full list of required KG composite indexes - Package layout section describing the new backends/firestore/ subpackage - Pyright CI and integration test references Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds end-to-end integration test results and critical documentation updates for the Firestore backend.
New —
docs/FIRESTORE_INTEGRATION_TEST_RESULTS.mdDocuments integration testing against a live Firestore database. 33/33 tests passing across:
Includes a complete drag-and-drop FastAPI reference server (~400 lines) so anyone can replicate the test setup.
Updated —
docs/FIRESTORE_BACKEND.mdIndex scope — Documents the critical distinction between
COLLECTIONandCOLLECTION_GROUPscope. When triples live in subcollections (e.g.users/{id}/memory/triples),COLLECTIONscope composite indexes don't apply and queries fail at runtime withFailedPrecondition: The query requires an index. All 5 required KG composite indexes are listed as ready-to-deploy JSON.Package layout — Documents the
backends/firestore/subpackage structure with the lazy__getattr__re-export pattern (ensures ChromaDB-only users don't need google-cloud-firestore installed).Testing — Adds pyright instructions and a link to the integration test results.
Why this matters
The
COLLECTIONvsCOLLECTION_GROUPgotcha cost hours of debugging during integration testing. Documenting it prevents the same trap for downstream users.🤖 Generated with Claude Code