configure_sigs.sh: Use less ambiguous identifier #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'number' might be used in the included header file(s) which then defeats the grep for the number. Thus use the less ambiguous identifier to avoid those type of clashes. Signed-off-by: Adam Lackorzynski <[email protected]>
admlck
added a commit
to admlck/bob-basement
that referenced
this pull request
Oct 31, 2025
perl-cross's signal detection mechanisms uses a commonly used word in a grep expression which can also catch lines not intended within this detection mechanism. Change the detection mechanism accordingly. This change is a PR to perl-cross: arsv/perl-cross#166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'number' might be used in the included header file(s) which then defeats the grep for the number. Thus use the less ambiguous identifier to avoid those type of clashes.