Open
Conversation
ykws
reviewed
Jan 18, 2022
ykws
left a comment
ykws
left a comment
There was a problem hiding this comment.
It's great!
However it's supported iOS9 or later on latest Xcode, so needs to update deployment_target as well.
Also, needs to update the following contents in the README.
- Requirements
- iOS 9.0+
- Xcode 13.2.1
Perhaps a minimal update of Xcode might be better.
This was referenced Jan 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified core files for compatibility with Swift 5.0. Bumped the version from 2.0.0 to 2.0.1. Modified Readme and .podspec files to match the upgrade. All changes have been made in the development branch only.