make company model swappable#30
Merged
walterrenner merged 1 commit intoarteria:masterfrom May 22, 2018
imposeren:use-swappable-model
Merged
make company model swappable#30walterrenner merged 1 commit intoarteria:masterfrom imposeren:use-swappable-model
walterrenner merged 1 commit intoarteria:masterfrom
imposeren:use-swappable-model
Conversation
|
@arteria, can you please merge it? |
Contributor
Author
|
@jvamvas, @walterrenner, can anyone from arteria please merge this and release new version on PyPI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Company model should be swappable. This should fix:
#25 #28
Also when custom model is used TestRunner is unable to serialize data for openninghours.Company:
This MR should fix this too