Fix auto-closing if used in open shadow DOM #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I wasn't sure if this project is still maintained, so I didn't want to put too much effort in this. If needed, I can add tests. |
I have zero time to maintain this project nor I use it anymore, so my suggestion is to fork it and use your fork instead. The project has a MIT license so you're fine to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes auto-closing of the calendar popup when the component is used in an open shadow DOM.
What is the current behavior?
When the component is used in an open shadow DOM, the popup is closed on any click, no matter whether it's in the popup or not.
What is the new behavior?
The popup is closed only if the user has clicked outside of the popup.
Checklist: