chore(lint): address most easy linting issues #trivial (#9516)

* chore(lint): adress some linting issues #trivial

* chore(lint): adress some more linting issues #trivial

* chore(lint): adress some more linting issues #trivial

dangerfile.ts

@@ -140,7 +140,7 @@ export const validatePRChangelog = () => {
   // and res contains a list of the changes
   console.log("PR Changelog is valid")
 
-  const { type, ...changedSections } = res
+  const { ...changedSections } = res
 
   const message =
     "### This PR contains the following changes:\n" +

src/app/Components/ArtworkFilter/Filters/MultiSelectOptionItem.tsx

@@ -1,8 +1,8 @@
 import { Check, CHECK_SIZE, Flex, Box, useSpace, Text } from "@artsy/palette-mobile"
 import { FilterData } from "app/Components/ArtworkFilter/ArtworkFilterHelpers"
 import { TouchableRow } from "app/Components/TouchableRow"
-import React, { memo } from "react"
 import { useScreenDimensions } from "app/utils/hooks"
+import React, { memo } from "react"
 import styled from "styled-components/native"
 
 const OPTIONS_MARGIN_LEFT = 0.5

src/app/Components/ArtworkFilter/Filters/YearOptions.tsx

@@ -13,9 +13,9 @@ import {
 } from "app/Components/ArtworkFilter/ArtworkFilterStore"
 import { ArtworkFilterBackHeader } from "app/Components/ArtworkFilter/components/ArtworkFilterBackHeader"
 import { TouchableRow } from "app/Components/TouchableRow"
+import { useScreenDimensions } from "app/utils/hooks"
 import React, { useState } from "react"
 import Haptic from "react-native-haptic-feedback"
-import { useScreenDimensions } from "app/utils/hooks"
 
 type YearOptionsScreenProps = StackScreenProps<ArtworkFilterNavigationStack, "YearOptionsScreen">
 

src/app/Components/Bidding/BidFlow.tests.tsx

@@ -1,10 +1,10 @@
+import { Checkbox } from "@artsy/palette-mobile"
 import { BidderPositionQuery$data } from "__generated__/BidderPositionQuery.graphql"
 import { bidderPositionQuery } from "app/Components/Bidding/Screens/ConfirmBid/BidderPositionQuery"
+import { Select } from "app/Components/Select"
 import { extractText } from "app/utils/tests/extractText"
 import { renderWithWrappersLEGACY } from "app/utils/tests/renderWithWrappers"
 import { waitUntil } from "app/utils/tests/waitUntil"
-import { Checkbox } from "@artsy/palette-mobile"
-import { Select } from "app/Components/Select"
 import "react-native"
 import relay from "react-relay"
 // @ts-expect-error

src/app/Components/Bidding/Components/ArtworkAuctionProgressBar.tests.tsx

@@ -1,5 +1,5 @@
-import { renderWithWrappers } from "app/utils/tests/renderWithWrappers"
 import { ProgressBar } from "@artsy/palette-mobile"
+import { renderWithWrappers } from "app/utils/tests/renderWithWrappers"
 
 import {
   ArtworkAuctionProgressBar,

src/app/Components/Bidding/Components/ArtworkAuctionProgressBar.tsx

@@ -1,5 +1,5 @@
-import { useTimer } from "app/utils/useTimer"
 import { ProgressBar } from "@artsy/palette-mobile"
+import { useTimer } from "app/utils/useTimer"
 
 export interface ArtworkAuctionProgressBarProps {
   startAt?: string | null
@@ -18,11 +18,12 @@ export const ArtworkAuctionProgressBar: React.FC<ArtworkAuctionProgressBarProps>
   hasBeenExtended,
   height,
 }) => {
+  const { time } = useTimer(biddingEndAt ?? "", startAt ?? "")
+
   if (!biddingEndAt) {
     return null
   }
 
-  const { time } = useTimer(biddingEndAt, startAt ?? "")
   const { days, hours, minutes, seconds } = time
 
   const parsedDaysUntilEnd = parseInt(days, 10)

src/app/Components/Buttons/BottomAlignedButtonWrapper.tsx

@@ -1,5 +1,5 @@
-import { View } from "react-native"
 import { ArtsyKeyboardAvoidingView } from "app/utils/ArtsyKeyboardAvoidingView"
+import { View } from "react-native"
 
 export interface BottomAlignedProps extends React.Props<JSX.Element> {
   onPress?: () => void

src/app/Components/Containers/RegistrationFlow.tsx

@@ -1,8 +1,8 @@
 import { TimeOffsetProvider } from "app/Components/Bidding/Context/TimeOffsetProvider"
 import { RegistrationQueryRenderer } from "app/Components/Bidding/Screens/Registration"
 import NavigatorIOS from "app/utils/__legacy_do_not_use__navigator-ios-shim"
-import { View } from "react-native"
 import { useScreenDimensions } from "app/utils/hooks"
+import { View } from "react-native"
 
 export const RegistrationFlow: React.FC<{ saleID: string }> = (props) => {
   return (

src/app/Components/HeaderArtworksFilter/HeaderArtworksFilter.tests.tsx

@@ -1,8 +1,7 @@
-import { Text } from "@artsy/palette-mobile"
+import { Text, TouchableHighlightColor } from "@artsy/palette-mobile"
 import { useAnimatedValue } from "app/Scenes/Artwork/Components/ImageCarousel/useAnimatedValue"
 import { extractText } from "app/utils/tests/extractText"
 import { renderWithWrappersLEGACY } from "app/utils/tests/renderWithWrappers"
-import { TouchableHighlightColor } from "@artsy/palette-mobile"
 import { act } from "react-test-renderer"
 import {
   FilterProps,

src/app/Components/LineGraph/LineGraphBands.tsx

@@ -1,5 +1,4 @@
-import { Flex, useColor, Text } from "@artsy/palette-mobile"
-import { Touchable } from "@artsy/palette-mobile"
+import { Flex, useColor, Text, Touchable } from "@artsy/palette-mobile"
 import { ColoredDot } from "./ColoredDot"
 
 export interface LineGraphBandProps {

src/app/Components/Lists/AuctionResultListItem.tests.tsx

@@ -1,11 +1,11 @@
+import { Touchable } from "@artsy/palette-mobile"
 import { AuctionResultListItemTestsQuery } from "__generated__/AuctionResultListItemTestsQuery.graphql"
 import { navigate } from "app/system/navigation/navigate"
 import { extractNodes } from "app/utils/extractNodes"
 import { extractText } from "app/utils/tests/extractText"
 import { renderWithWrappersLEGACY } from "app/utils/tests/renderWithWrappers"
 import { resolveMostRecentRelayOperation } from "app/utils/tests/resolveMostRecentRelayOperation"
 import moment from "moment"
-import { Touchable } from "@artsy/palette-mobile"
 import { graphql, QueryRenderer } from "react-relay"
 import { createMockEnvironment } from "relay-test-utils"
 import { AuctionResultListItemFragmentContainer } from "./AuctionResultListItem"

src/app/Components/PhotoRow/PhotoRow.tsx

@@ -24,7 +24,7 @@ const PhotoRowContainer: React.FC<PhotoRowContainerProps> = ({ error, errorMsg,
     >
       {children}
     </Flex>
-    {error && errorMsg && (
+    {!!error && !!errorMsg && (
       <Text variant="xs" color="red100">
         {errorMsg}
       </Text>

src/app/Components/PopoverMessage/PopoverMessage.tests.tsx

@@ -1,6 +1,6 @@
+import { Touchable } from "@artsy/palette-mobile"
 import { flushPromiseQueue } from "app/utils/tests/flushPromiseQueue"
 import { renderWithWrappersLEGACY } from "app/utils/tests/renderWithWrappers"
-import { Touchable } from "@artsy/palette-mobile"
 import { Text } from "react-native"
 import { act } from "react-test-renderer"
 import { AnimatedFlex, PopoverMessage, PopoverMessageItem } from "./PopoverMessage"

src/app/Components/PopoverMessage/PopoverMessage.tsx

@@ -1,7 +1,6 @@
-import { Flex, Box, useColor, Text } from "@artsy/palette-mobile"
-import { Touchable } from "@artsy/palette-mobile"
-import { Animated, StyleProp, ViewStyle } from "react-native"
+import { Flex, Box, useColor, Text, Touchable } from "@artsy/palette-mobile"
 import { useScreenDimensions } from "app/utils/hooks"
+import { Animated, StyleProp, ViewStyle } from "react-native"
 import { usePopoverMessage } from "./popoverMessageHooks"
 
 export const AnimatedFlex = Animated.createAnimatedComponent(Flex)

src/app/Components/ReadMore.tsx

@@ -147,7 +147,7 @@ export const ReadMore = React.memo(
     return isAlreadyExpanded ? (
       <Flex>
         {root}
-        {showReadLessButton && isExpanded && (
+        {!!showReadLessButton && !!isExpanded && (
           <LinkText
             mt={0.5}
             mb={1}

src/app/Components/Toast/Toast.tests.tsx

@@ -1,6 +1,6 @@
+import { Touchable } from "@artsy/palette-mobile"
 import { fireEvent } from "@testing-library/react-native"
 import { renderWithWrappers } from "app/utils/tests/renderWithWrappers"
-import { Touchable } from "@artsy/palette-mobile"
 import { Text } from "react-native"
 import { ToastComponent, TOAST_DURATION_MAP } from "./ToastComponent"
 import { useToast } from "./toastHook"

src/app/Components/TouchableRow.tsx

@@ -1,5 +1,4 @@
-import { useColor } from "@artsy/palette-mobile"
-import { Touchable, TouchableProps } from "@artsy/palette-mobile"
+import { useColor, Touchable, TouchableProps } from "@artsy/palette-mobile"
 
 export type TouchableRowProps = TouchableProps
 

src/app/Scenes/ArtistSeries/ArtistSeries.tests.tsx

@@ -1,20 +1,18 @@
+import { Touchable } from "@artsy/palette-mobile"
 import { ArtistSeriesTestsQuery } from "__generated__/ArtistSeriesTestsQuery.graphql"
 import { ArtworkFiltersStoreProvider } from "app/Components/ArtworkFilter/ArtworkFilterStore"
 import { ArtistSeries, ArtistSeriesFragmentContainer } from "app/Scenes/ArtistSeries/ArtistSeries"
 import { ArtistSeriesArtworks } from "app/Scenes/ArtistSeries/ArtistSeriesArtworks"
 import { ArtistSeriesHeader } from "app/Scenes/ArtistSeries/ArtistSeriesHeader"
 import { ArtistSeriesMeta } from "app/Scenes/ArtistSeries/ArtistSeriesMeta"
 import { ArtistSeriesMoreSeries } from "app/Scenes/ArtistSeries/ArtistSeriesMoreSeries"
+import { mockTrackEvent } from "app/utils/tests/globallyMockedStuff"
 import { renderWithWrappersLEGACY } from "app/utils/tests/renderWithWrappers"
-import { Touchable } from "@artsy/palette-mobile"
 import { graphql, QueryRenderer } from "react-relay"
 import { act } from "react-test-renderer"
-import { useTracking } from "react-tracking"
 import { createMockEnvironment, MockPayloadGenerator } from "relay-test-utils"
 import { ArtistSeriesListItem } from "./ArtistSeriesListItem"
 
-const trackEvent = useTracking().trackEvent
-
 describe("Artist Series Rail", () => {
   let env: ReturnType<typeof createMockEnvironment>
 
@@ -78,7 +76,7 @@ describe("Artist Series Rail", () => {
     const artistSeriesButton = wrapper.root.findByType(ArtistSeriesListItem).findByType(Touchable)
     act(() => artistSeriesButton.props.onPress())
 
-    expect(trackEvent).toHaveBeenCalledWith({
+    expect(mockTrackEvent).toHaveBeenCalledWith({
       action: "tappedArtistSeriesGroup",
       context_module: "moreSeriesByThisArtist",
       context_screen_owner_id: "abc",

src/app/Scenes/ArtistSeries/ArtistSeriesFullArtistSeriesList.tests.tsx

@@ -1,10 +1,10 @@
+import { Touchable } from "@artsy/palette-mobile"
 import { ArtistSeriesFullArtistSeriesListTestsQuery } from "__generated__/ArtistSeriesFullArtistSeriesListTestsQuery.graphql"
 import { ArtistSeriesFullArtistSeriesListFragmentContainer } from "app/Scenes/ArtistSeries/ArtistSeriesFullArtistSeriesList"
 import { ArtistSeriesListItem } from "app/Scenes/ArtistSeries/ArtistSeriesListItem"
 import { extractText } from "app/utils/tests/extractText"
 import { mockTrackEvent } from "app/utils/tests/globallyMockedStuff"
 import { renderWithWrappersLEGACY } from "app/utils/tests/renderWithWrappers"
-import { Touchable } from "@artsy/palette-mobile"
 import { graphql, QueryRenderer } from "react-relay"
 import { act } from "react-test-renderer"
 import { createMockEnvironment } from "relay-test-utils"

src/app/Scenes/ArtistSeries/ArtistSeriesListItem.tests.tsx

@@ -1,10 +1,10 @@
 import { OwnerType } from "@artsy/cohesion"
+import { Touchable } from "@artsy/palette-mobile"
 import OpaqueImageView from "app/Components/OpaqueImageView/OpaqueImageView"
 import { ArtistSeriesListItem } from "app/Scenes/ArtistSeries/ArtistSeriesListItem"
 import { ArtistSeriesConnectionEdge } from "app/Scenes/ArtistSeries/ArtistSeriesMoreSeries"
 import { navigate } from "app/system/navigation/navigate"
 import { renderWithWrappersLEGACY } from "app/utils/tests/renderWithWrappers"
-import { Touchable } from "@artsy/palette-mobile"
 import { act } from "react-test-renderer"
 
 describe("ArtistSeriesListItem", () => {

src/app/Scenes/ArtistSeries/ArtistSeriesListItem.tsx

@@ -5,11 +5,10 @@ import {
   ScreenOwnerType,
   TappedArtistSeriesGroup,
 } from "@artsy/cohesion"
-import { ArrowRightIcon, Flex, useColor, Text } from "@artsy/palette-mobile"
+import { ArrowRightIcon, Flex, useColor, Text, Touchable } from "@artsy/palette-mobile"
 import OpaqueImageView from "app/Components/OpaqueImageView/OpaqueImageView"
 import { ArtistSeriesConnectionEdge } from "app/Scenes/ArtistSeries/ArtistSeriesMoreSeries"
 import { navigate } from "app/system/navigation/navigate"
-import { Touchable } from "@artsy/palette-mobile"
 import { useTracking } from "react-tracking"
 
 interface ArtistSeriesListItemProps {

src/app/Scenes/ArtistSeries/ArtistSeriesMoreSeries.tests.tsx

@@ -1,19 +1,17 @@
 import { ContextModule, OwnerType } from "@artsy/cohesion"
+import { Touchable } from "@artsy/palette-mobile"
 import { ArtistSeriesMoreSeriesTestsQuery } from "__generated__/ArtistSeriesMoreSeriesTestsQuery.graphql"
 import { ArtistSeriesListItem } from "app/Scenes/ArtistSeries/ArtistSeriesListItem"
 import {
   ArtistSeriesMoreSeries,
   ArtistSeriesMoreSeriesFragmentContainer,
 } from "app/Scenes/ArtistSeries/ArtistSeriesMoreSeries"
+import { mockTrackEvent } from "app/utils/tests/globallyMockedStuff"
 import { renderWithWrappersLEGACY } from "app/utils/tests/renderWithWrappers"
-import { Touchable } from "@artsy/palette-mobile"
 import { graphql, QueryRenderer } from "react-relay"
 import { act } from "react-test-renderer"
-import { useTracking } from "react-tracking"
 import { createMockEnvironment } from "relay-test-utils"
 
-const trackEvent = useTracking().trackEvent
-
 describe("ArtistSeriesMoreSeries", () => {
   let env: ReturnType<typeof createMockEnvironment>
 
@@ -92,7 +90,7 @@ describe("ArtistSeriesMoreSeries", () => {
 
       act(() => artistSeriesButton.props.onPress())
 
-      expect(trackEvent).toHaveBeenCalledWith({
+      expect(mockTrackEvent).toHaveBeenCalledWith({
         action: "tappedArtistSeriesGroup",
         context_module: "artistSeriesRail",
         context_screen_owner_id: "artist-series-id",

src/app/Scenes/Artwork/Components/CommercialButtons/BidButton.tsx

@@ -122,21 +122,21 @@ export class BidButton extends React.Component<BidButtonProps> {
             >
               Register to bid
             </Button>
-            {needsIdentityVerification && (
+            {!!needsIdentityVerification && (
               <IdentityVerificationRequiredMessage
                 onPress={() => this.redirectToIdentityVerificationFAQ()}
               />
             )}
           </>
         )}
-        {registrationStatus && !registrationStatus.qualifiedForBidding && (
+        {!!registrationStatus && !registrationStatus.qualifiedForBidding && (
           <>
             <Button width={100} block size="large" mt={1} variant={this.props.variant} disabled>
               Registration Pending
             </Button>
           </>
         )}
-        {registrationStatus?.qualifiedForBidding && (
+        {!!registrationStatus?.qualifiedForBidding && (
           <Button width={100} block size="large" mt={1} variant={this.props.variant} disabled>
             Registration complete
           </Button>
@@ -151,7 +151,7 @@ export class BidButton extends React.Component<BidButtonProps> {
     const isWatchOnly = watchOnly(sale)
     return (
       <>
-        {isWatchOnly && (
+        {!!isWatchOnly && (
           <ClassTheme>
             {({ color }) => (
               <Text variant="sm-display" color={color("black60")} pb={1} textAlign="center">

src/app/Scenes/Artwork/Components/CommercialButtons/CollapsibleArtworkDetails.tsx

@@ -84,7 +84,7 @@ export const CollapsibleArtworkDetails: React.FC<CollapsibleArtworkDetailsProps>
           </ScrollView>
         </Box>
       </Collapse>
-      {hasSeparator && <Separator />}
+      {!!hasSeparator && <Separator />}
     </>
   ) : null
 }

src/app/Scenes/Artwork/Components/ImageCarousel/FullScreen/DeepZoom/DeepZoomLevel.tsx

@@ -3,10 +3,10 @@ import {
   useEvents,
 } from "app/Scenes/Artwork/Components/ImageCarousel/FullScreen/useEventStream"
 import { Rect, Size } from "app/Scenes/Artwork/Components/ImageCarousel/geometry"
+import { useScreenDimensions } from "app/utils/hooks"
 import { throttle } from "lodash"
 import React, { useCallback, useEffect, useMemo, useRef, useState } from "react"
 import { Animated } from "react-native"
-import { useScreenDimensions } from "app/utils/hooks"
 import { DeepZoomPyramid } from "./DeepZoomPyramid"
 import { DeepZoomTile, DeepZoomTileID } from "./DeepZoomTile"
 import { VISUAL_DEBUG_MODE } from "./__deepZoomDebug"

src/app/Scenes/Artwork/Components/ImageCarousel/FullScreen/DeepZoom/DeepZoomOverlay.tsx

@@ -1,9 +1,9 @@
 import { EventStream } from "app/Scenes/Artwork/Components/ImageCarousel/FullScreen/useEventStream"
 import { ImageDescriptor } from "app/Scenes/Artwork/Components/ImageCarousel/ImageCarouselContext"
 import { fitInside, Rect } from "app/Scenes/Artwork/Components/ImageCarousel/geometry"
+import { useScreenDimensions } from "app/utils/hooks"
 import React, { useEffect, useMemo } from "react"
 import { Animated, View } from "react-native"
-import { useScreenDimensions } from "app/utils/hooks"
 import { DeepZoomLevel } from "./DeepZoomLevel"
 import { DeepZoomPyramid } from "./DeepZoomPyramid"
 import {

src/app/Scenes/Artwork/Components/ImageCarousel/FullScreen/ImageCarouselCloseButton.tsx

@@ -1,8 +1,8 @@
 import { CloseIcon } from "@artsy/palette-mobile"
 import { ImageCarouselContext } from "app/Scenes/Artwork/Components/ImageCarousel/ImageCarouselContext"
+import { useScreenDimensions } from "app/utils/hooks"
 import { useContext } from "react"
 import { TouchableOpacity, View } from "react-native"
-import { useScreenDimensions } from "app/utils/hooks"
 import { boxShadow } from "./boxShadow"
 
 // taken from https://github.com/artsy/eigen/blob/0831853cb574566415f3bd8b3908b26b61f61eec/Artsy/View_Controllers/Util/ARNavigationController.m#L125

src/app/Scenes/Artwork/Components/ImageCarousel/FullScreen/StatusBarOverlay.tsx

@@ -1,5 +1,5 @@
-import { Animated } from "react-native"
 import { useScreenDimensions } from "app/utils/hooks"
+import { Animated } from "react-native"
 import { useSpringFade } from "./useSpringFade"
 
 // used to mask the image during initial transition in case the user has scrolled down some

src/app/Scenes/Artwork/Components/ImageCarousel/FullScreen/VerticalSwipeToDismiss.tsx

@@ -1,8 +1,8 @@
 import { ImageCarouselContext } from "app/Scenes/Artwork/Components/ImageCarousel/ImageCarouselContext"
 import { useAnimatedValue } from "app/Scenes/Artwork/Components/ImageCarousel/useAnimatedValue"
+import { useScreenDimensions } from "app/utils/hooks"
 import { useCallback, useContext, useEffect, useMemo, useRef } from "react"
 import { Animated, NativeScrollEvent, NativeSyntheticEvent, ScrollView, View } from "react-native"
-import { useScreenDimensions } from "app/utils/hooks"
 
 /**
  * Wraps the content in a scroll view which provides a 'vertical swipe' facility.

src/app/Scenes/Artwork/Components/ImageCarousel/ImageCarouselVimeoVideo.tsx

@@ -1,6 +1,5 @@
 import querystring from "querystring"
-import { Flex } from "@artsy/palette-mobile"
-import { Touchable } from "@artsy/palette-mobile"
+import { Flex, Touchable } from "@artsy/palette-mobile"
 import { useEffect, useState } from "react"
 import { Image } from "react-native"
 import { Config } from "react-native-config"
@@ -42,7 +41,7 @@ export const ImageCarouselVimeoVideo: React.FC<ImageCarouselVimeoVideoProps> = (
       accessibilityLabel="Vimeo Video Player"
       alignContent="center"
     >
-      {coverImage && !isPlaying && (
+      {!!coverImage && !isPlaying && (
         <Touchable onPress={() => setIsPlaying(true)} accessibilityLabel="Vimeo Play Button">
           <Image
             source={{ uri: coverImage }}
@@ -51,7 +50,7 @@ export const ImageCarouselVimeoVideo: React.FC<ImageCarouselVimeoVideoProps> = (
           />
         </Touchable>
       )}
-      {isPlaying && (
+      {!!isPlaying && (
         <Flex accessibilityLabel="Vimeo Video Player Controls" width="100%" height="100%">
           <Vimeo
             videoId={videoId}