ci(fix): fix nightly, upgrade xcode to 16 (#11181)

* bring back xcode upgrade * revert me: only run nightly for testing * update all xcode versions * update ruby version in the project * update versions in doctor script * update known exception to fix erroneous pod check error * Revert "revert me: only run nightly for testing" This reverts commit ef07dcf. * update nimble snapshots to fix xcode 16 build error * update device for tests * updated snapshots * revert me: record snapshots * Revert "revert me: record snapshots" This reverts commit 24d9a9a. * delete interfering old snapshots * delete interfering old snapshots * revert me: list sims * use available sim runtime * update version in docs
artsy · Nov 25, 2024 · ce85c9b · ce85c9b
1 parent 0065ee9
commit ce85c9b
Show file tree

Hide file tree

Showing 74 changed files with 26 additions and 26 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -185,7 +185,7 @@ jobs:
       BUNDLE_PATH: .vendor
 
     macos:
-      xcode: 15.1
+      xcode: 16.1
       resource_class: macos.m1.medium.gen1
 
     steps:
@@ -206,7 +206,7 @@ jobs:
       BUNDLE_PATH: .vendor
 
     macos:
-      xcode: 15.1
+      xcode: 16.1
       resource_class: macos.m1.medium.gen1
 
     steps:
@@ -227,7 +227,7 @@ jobs:
       BUNDLE_PATH: .vendor
 
     macos:
-      xcode: 15.1
+      xcode: 16.1
       resource_class: macos.m1.medium.gen1
 
     steps:
@@ -322,7 +322,7 @@ jobs:
       BUNDLE_PATH: .vendor # path to install gems and use for caching
 
     macos:
-      xcode: 15.1
+      xcode: 16.1
       resource_class: macos.m1.medium.gen1
 
     steps:
@@ -406,7 +406,7 @@ jobs:
       BUNDLE_PATH: .vendor # path to install gems and use for caching
 
     macos:
-      xcode: 15.1
+      xcode: 16.1
       resource_class: macos.m1.medium.gen1
 
     steps:
@@ -447,9 +447,9 @@ jobs:
       - install-gems
       - install-cocoapods
       - macos/preboot-simulator:
-          version: "17.2"
+          version: "18.1"
           platform: "iOS"
-          device: "iPhone 15 Pro"
+          device: "iPhone 16 Pro"
       - build-app-ios
       - macos/install-rosetta
       - run:

diff --git a/.ruby-version b/.ruby-version
@@ -1 +1 @@
-3.1.4
+3.1.6
diff --git a/.tool-versions b/.tool-versions
@@ -1,3 +1,3 @@
 nodejs 20.9.0
-ruby 3.1.4
+ruby 3.1.6
 java zulu-17.50.19
diff --git a/docs/getting_started.md b/docs/getting_started.md
@@ -21,7 +21,7 @@ asdf plugin add java
 
 ### Set up iOS
 
-Download Xcode version 15. You can find all available versions of Xcode at [Apple's Developer Portal 🔐](http://developer.apple.com/download/more/).
+Download Xcode version 16. You can find all available versions of Xcode at [Apple's Developer Portal 🔐](http://developer.apple.com/download/more/).
 
 Ask your mentor to add you on the [firebase.console](https://console.firebase.google.com/project/eigen-a7d3b/settings/iam) to be able to release.
 

diff --git a/...s/ReferenceImages/ARAugmentedVIRViewControllerSpec/defaults_to_showing_info.png b/...s/ReferenceImages/ARAugmentedVIRViewControllerSpec/defaults_to_showing_info.png
diff --git a/...eferenceImages/ARAugmentedVIRViewControllerSpec/[email protected] b/...eferenceImages/ARAugmentedVIRViewControllerSpec/[email protected]
diff --git a/...gmentedVIRViewControllerSpec/shows_the_right_info_when_a_wall_is_registered.png b/...gmentedVIRViewControllerSpec/shows_the_right_info_when_a_wall_is_registered.png
diff --git a/...ntedVIRViewControllerSpec/[email protected] b/...ntedVIRViewControllerSpec/[email protected]
diff --git a/...mentedVIRViewControllerSpec/shows_the_right_info_when_an_artwork_was_placed.png b/...mentedVIRViewControllerSpec/shows_the_right_info_when_an_artwork_was_placed.png
diff --git a/...tedVIRViewControllerSpec/[email protected] b/...tedVIRViewControllerSpec/[email protected]
diff --git a/...mages/ARBidButtonSpec/an_open_aution_takes_priority_over_registered_bidding.png b/...mages/ARBidButtonSpec/an_open_aution_takes_priority_over_registered_bidding.png
diff --git a/...es/ARBidButtonSpec/[email protected] b/...es/ARBidButtonSpec/[email protected]
diff --git a/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/testBiddingClosedState.png b/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/testBiddingClosedState.png
diff --git a/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/[email protected] b/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/[email protected]
diff --git a/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/testBiddingOpenState.png b/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/testBiddingOpenState.png
diff --git a/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/[email protected] b/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/[email protected]
diff --git a/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/testBiddingRegistrationClosed.png b/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/testBiddingRegistrationClosed.png
diff --git a/...ArtsyTests/ReferenceImages/ARBidButtonSpec/[email protected] b/...ArtsyTests/ReferenceImages/ARBidButtonSpec/[email protected]
diff --git a/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/testBiddingRegistrationPending.png b/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/testBiddingRegistrationPending.png
diff --git a/...rtsyTests/ReferenceImages/ARBidButtonSpec/[email protected] b/...rtsyTests/ReferenceImages/ARBidButtonSpec/[email protected]
diff --git a/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/testRegisterForceBidState.png b/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/testRegisterForceBidState.png
diff --git a/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/[email protected] b/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/[email protected]
diff --git a/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/testRegisterState.png b/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/testRegisterState.png
diff --git a/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/[email protected] b/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/[email protected]
diff --git a/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/testRegisteredState.png b/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/testRegisteredState.png
diff --git a/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/[email protected] b/ios/ArtsyTests/ReferenceImages/ARBidButtonSpec/[email protected]
diff --git a/...syTests/ReferenceImages/ARCustomEigenLabelsSpec/ARWarningView_looks_correct.png b/...syTests/ReferenceImages/ARCustomEigenLabelsSpec/ARWarningView_looks_correct.png
diff --git a/...onSpecSpec/ARNavigationButton_default_border_really_long_title_and_subtitle.png b/...onSpecSpec/ARNavigationButton_default_border_really_long_title_and_subtitle.png
diff --git a/...gationButtonSpecSpec/ARSerifNavigationButton_really_long_title_and_subtitle.png b/...gationButtonSpecSpec/ARSerifNavigationButton_really_long_title_and_subtitle.png
diff --git a/...yTests/ReferenceImages/ARNavigationButtonSpecSpec/navigationButtonWithTitle.png b/...yTests/ReferenceImages/ARNavigationButtonSpecSpec/navigationButtonWithTitle.png
diff --git a/...enceImages/ARNavigationButtonSpecSpec/navigationButtonWithTitleAnd5pxBorder.png b/...enceImages/ARNavigationButtonSpecSpec/navigationButtonWithTitleAnd5pxBorder.png
diff --git a/...renceImages/ARNavigationButtonSpecSpec/navigationButtonWithTitleAndNoBorder.png b/...renceImages/ARNavigationButtonSpecSpec/navigationButtonWithTitleAndNoBorder.png
diff --git a/...renceImages/ARNavigationButtonSpecSpec/navigationButtonWithTitleAndSubtitle.png b/...renceImages/ARNavigationButtonSpecSpec/navigationButtonWithTitleAndSubtitle.png
diff --git a/...ARNavigationButtonSpecSpec/navigationButtonWithTitleAndSubtitleAnd5pxBorder.png b/...ARNavigationButtonSpecSpec/navigationButtonWithTitleAndSubtitleAnd5pxBorder.png
diff --git a/.../ARNavigationButtonSpecSpec/navigationButtonWithTitleAndSubtitleAndNoBorder.png b/.../ARNavigationButtonSpecSpec/navigationButtonWithTitleAndSubtitleAndNoBorder.png
diff --git a/...s/ReferenceImages/ARNavigationButtonSpecSpec/serifNavigationButtonWithTitle.png b/...s/ReferenceImages/ARNavigationButtonSpecSpec/serifNavigationButtonWithTitle.png
diff --git a/...Images/ARNavigationButtonSpecSpec/serifNavigationButtonWithTitleAndSubtitle.png b/...Images/ARNavigationButtonSpecSpec/serifNavigationButtonWithTitleAndSubtitle.png
diff --git a/[email protected] → .../visuals_should_be_empty_for_a_rootVC.png b/[email protected] → .../visuals_should_be_empty_for_a_rootVC.png
diff --git a/[email protected] → ...a_back_button_with_2_view_controllers.png b/[email protected] → ...a_back_button_with_2_view_controllers.png
diff --git a/...ages/ARSerifNavigationViewControllerSpec/_handles_the_back_button_correctly.png b/...ages/ARSerifNavigationViewControllerSpec/_handles_the_back_button_correctly.png
diff --git a/...s/ARSerifNavigationViewControllerSpec/[email protected] b/...s/ARSerifNavigationViewControllerSpec/[email protected]
diff --git a/...ationViewControllerSpec/_handles_the_fake_navigation_close_button_correctly.png b/...ationViewControllerSpec/_handles_the_fake_navigation_close_button_correctly.png
diff --git a/...onViewControllerSpec/[email protected] b/...onViewControllerSpec/[email protected]
diff --git a/...ferenceImages/ARTextViewSpec/with_HTML_looks_right_with_multiple_paragraphs.png b/...ferenceImages/ARTextViewSpec/with_HTML_looks_right_with_multiple_paragraphs.png
diff --git a/...onInformationViewControllerTests/[email protected] b/...onInformationViewControllerTests/[email protected]
diff --git a/...handles_getting_outbid_with_lot_state_changes_before_animation_completes@3x.png b/...handles_getting_outbid_with_lot_state_changes_before_animation_completes@3x.png
diff --git a/...ts/ReferenceImages/LiveAuctionBidButtonTests/[email protected] b/...ts/ReferenceImages/LiveAuctionBidButtonTests/[email protected]
diff --git a/...ests/ReferenceImages/LiveAuctionBidButtonTests/[email protected] b/...ests/ReferenceImages/LiveAuctionBidButtonTests/[email protected]
diff --git a/...ests/ReferenceImages/LiveAuctionBidButtonTests/[email protected] b/...ests/ReferenceImages/LiveAuctionBidButtonTests/[email protected]
diff --git a/...eAuctionBidButtonTests/[email protected] b/...eAuctionBidButtonTests/[email protected]
diff --git a/...ReferenceImages/LiveAuctionBidButtonTests/[email protected] b/...ReferenceImages/LiveAuctionBidButtonTests/[email protected]
diff --git a/.../ReferenceImages/LiveAuctionBidButtonTests/[email protected] b/.../ReferenceImages/LiveAuctionBidButtonTests/[email protected]
diff --git a/...erenceImages/LiveAuctionBidButtonTests/[email protected] b/...erenceImages/LiveAuctionBidButtonTests/[email protected]
diff --git a/...ests/ReferenceImages/LiveAuctionBidButtonTests/[email protected] b/...ests/ReferenceImages/LiveAuctionBidButtonTests/[email protected]
diff --git a/...eImages/LiveAuctionBidButtonTests/[email protected] b/...eImages/LiveAuctionBidButtonTests/[email protected]
diff --git a/...Images/LiveAuctionBidButtonTests/[email protected] b/...Images/LiveAuctionBidButtonTests/[email protected]
diff --git a/...mages/LiveAuctionBidButtonTests/[email protected] b/...mages/LiveAuctionBidButtonTests/[email protected]
diff --git a/...yTests/ReferenceImages/LiveAuctionBidButtonTests/[email protected] b/...yTests/ReferenceImages/LiveAuctionBidButtonTests/[email protected]
diff --git a/...ts/ReferenceImages/LiveAuctionBidButtonTests/[email protected] b/...ts/ReferenceImages/LiveAuctionBidButtonTests/[email protected]
diff --git a/...sts/ReferenceImages/LiveAuctionBidButtonTests/[email protected] b/...sts/ReferenceImages/LiveAuctionBidButtonTests/[email protected]
diff --git a/...tionBidButtonTests/[email protected] b/...tionBidButtonTests/[email protected]
diff --git a/...syTests/ReferenceImages/LiveAuctionLoadingViewSpec/[email protected] b/...syTests/ReferenceImages/LiveAuctionLoadingViewSpec/[email protected]
diff --git a/...eAuctionLotListStickyCellCollectionViewLayoutTests/[email protected] b/...eAuctionLotListStickyCellCollectionViewLayoutTests/[email protected]
diff --git a/...tStickyCellCollectionViewLayoutTests/[email protected] b/...tStickyCellCollectionViewLayoutTests/[email protected]
diff --git a/...ListStickyCellCollectionViewLayoutTests/[email protected] b/...ListStickyCellCollectionViewLayoutTests/[email protected]
diff --git a/...eferenceImages/SaleOnHoldOverlayViewTests/[email protected] b/...eferenceImages/SaleOnHoldOverlayViewTests/[email protected]
diff --git a/...erenceImages/SaleOnHoldOverlayViewTests/[email protected] b/...erenceImages/SaleOnHoldOverlayViewTests/[email protected]
diff --git a/...ges/SaleOnHoldOverlayViewTests/[email protected] b/...ges/SaleOnHoldOverlayViewTests/[email protected]
diff --git a/...s/SaleOnHoldOverlayViewTests/[email protected] b/...s/SaleOnHoldOverlayViewTests/[email protected]
diff --git a/ios/ArtsyTests/Supporting_Files/ARTestHelper.m b/ios/ArtsyTests/Supporting_Files/ARTestHelper.m
@@ -16,12 +16,12 @@ - (BOOL)application:(UIApplication *)application willFinishLaunchingWithOptions:
 {
     NSOperatingSystemVersion version = [NSProcessInfo processInfo].operatingSystemVersion;
 
-    NSAssert(version.majorVersion == 17 && version.minorVersion == 2,
-             @"The tests should be run on iOS 17.2, not %ld.%ld", version.majorVersion, version.minorVersion);
+    NSAssert(version.majorVersion == 18 && version.minorVersion == 1,
+             @"The tests should be run on iOS 18.1, not %ld.%ld", version.majorVersion, version.minorVersion);
 
     CGSize nativeResolution = [UIScreen mainScreen].nativeBounds.size;
-    NSAssert([UIDevice currentDevice].userInterfaceIdiom == UIUserInterfaceIdiomPhone && CGSizeEqualToSize(nativeResolution, CGSizeMake(1179, 2556)),
-             @"The tests should be run on an iPhone 15 Pro, not a device with native resolution %@",
+    NSAssert([UIDevice currentDevice].userInterfaceIdiom == UIUserInterfaceIdiomPhone && CGSizeEqualToSize(nativeResolution, CGSizeMake(1206, 2622)),
+             @"The tests should be run on an iPhone 16 Pro, not a device with native resolution %@",
              NSStringFromCGSize(nativeResolution));
 
     ARPerformWorkAsynchronously = NO;

diff --git a/ios/Podfile b/ios/Podfile
@@ -145,7 +145,7 @@ target 'Artsy' do
     # Swift pods 🎉
     pod 'Quick', '2.0.0'
     pod 'Nimble', '~> 13.0'
-    pod 'Nimble-Snapshots', '9.7.0'
+    pod 'Nimble-Snapshots', '9.8.0'
   end
 
   post_install do |installer|

diff --git a/ios/Podfile.lock b/ios/Podfile.lock
@@ -240,9 +240,9 @@ PODS:
   - nanopb/encode (2.30910.0)
   - Nimble (13.2.1):
     - CwlPreconditionTesting (~> 2.2.0)
-  - Nimble-Snapshots (9.7.0):
-    - Nimble-Snapshots/Core (= 9.7.0)
-  - Nimble-Snapshots/Core (9.7.0):
+  - Nimble-Snapshots (9.8.0):
+    - Nimble-Snapshots/Core (= 9.8.0)
+  - Nimble-Snapshots/Core (9.8.0):
     - iOSSnapshotTestCase (~> 8.0)
     - Nimble (~> 13.0)
   - ObjectiveSugar (1.1.0)
@@ -2200,7 +2200,7 @@ DEPENDENCIES:
   - MultiDelegate
   - nanopb
   - Nimble (~> 13.0)
-  - Nimble-Snapshots (= 9.7.0)
+  - Nimble-Snapshots (= 9.8.0)
   - ObjectiveSugar
   - OCMock
   - OHHTTPStubs (= 3.1.2)
@@ -2721,7 +2721,7 @@ SPEC CHECKSUMS:
   MultiDelegate: 228e2321b74f45ea43ae19c268fdd60fd88d99b7
   nanopb: 438bc412db1928dac798aa6fd75726007be04262
   Nimble: 9e81a67096dab1d1f5160d7a3f8fa7a1eeec38fd
-  Nimble-Snapshots: 7f2710c507469eb0fc4912f45d0f280e15f91966
+  Nimble-Snapshots: 240ea76ee8e52dfc1387b8d0d9bf1db3420cabbd
   ObjectiveSugar: a6a25f23d657c19df0a0b972466d5b5ca9f5295c
   OCMock: 9491e4bec59e0b267d52a9184ff5605995e74be8
   OHHTTPStubs: c93230597bc5c8b74bcfdb403cc8773515b8b08c
@@ -2851,6 +2851,6 @@ SPEC CHECKSUMS:
   "XCTest+OHHTTPStubSuiteCleanUp": 4469ec8863c6bc022c5089a9b94233eb3416c5ee
   Yoga: 055f92ad73f8c8600a93f0e25ac0b2344c3b07e6
 
-PODFILE CHECKSUM: 46318adcb474038e55e674055ad6287fc96886af
+PODFILE CHECKSUM: 1ad2c11c9fcf27a0ecd1b21668bca159cfeb9ed8
 
 COCOAPODS: 1.14.3
diff --git a/scripts/ci/ci-setup-export-vars b/scripts/ci/ci-setup-export-vars
@@ -10,7 +10,7 @@ export LOCAL_BRANCH
 export WORKSPACE="ios/Artsy.xcworkspace"
 export SCHEME="Artsy"
 export DEVICE_HOST_PLAT="iOS Simulator"
-export DEVICE_HOST_OS="17.2"
-export DEVICE_HOST_NAME="iPhone 15 Pro"
+export DEVICE_HOST_OS="18.1"
+export DEVICE_HOST_NAME="iPhone 16 Pro"
 export DERIVED_DATA_PATH="derived_data"
 export CONFIGURATION="Release"
diff --git a/scripts/utils/doctor.js b/scripts/utils/doctor.js
@@ -13,9 +13,9 @@ const fs = require("fs")
 const chalk = require("chalk")
 
 const desiredVersions = {
-  xcode: "15.0",
+  xcode: "16.1",
   androidStudio: "2022.3",
-  ruby: "3.1.4",
+  ruby: "3.1.6",
   bundler: "2.4.3",
 }
 
@@ -161,7 +161,7 @@ const checkPodDependenciesAreUpToDate = async () => {
     // https://github.com/square/cocoapods-check/issues/18
     // This is a bug for some react native deps in cocoapods-check
     // might be a nice OSS contribution opportunity!
-    const knownException = `~RNImageCropPicker, ~RNPermissions, ~React-Codegen\n[!] \`pod install\` will install 3 Pods.`
+    const knownException = `~RNFastImage, ~RNImageCropPicker, ~RNPermissions, ~RNShare, ~React-RCTFabric, ~ReactCodegen, ~react-native-blob-util, ~react-native-view-shot\n[!] \`pod install\` will install 8 Pods.`
 
     // pod check will return status 1 even for only warnings
     if (status !== 0) {