feat(perf): search perf #11096
feat(perf): search perf #11096
Conversation
| @@ -87,6 +91,7 @@ export const EntitySearchResults: React.FC<SearchResultsProps> = ({ query, selec | |||
| } | |||
| onScrollBeginDrag={handleOnScrollBeginDrag} | |||
| onEndReached={handleLoadMore} | |||
| onEndReachedThreshold={0.5} | |||
There was a problem hiding this comment.
updated this because the default was pretty choppy, scroll a small amount and get hard stop and loading indicator, was not very scientific but this seems to be smoother and load ahead of time when scrolling at a reasonable rate.
|
|
||
| const ESTIMATED_ITEM_SIZE = 60 | ||
|
|
||
| export function AboveTheFoldFlashList<ItemType>(props: AboveTheFoldFlashListProps<ItemType>) { |
There was a problem hiding this comment.
added a new component rather than replacing everywhere because I tried and it broke a bunch of stuff, they are probably just style issues
| @@ -188,9 +208,9 @@ const AutosuggestResultsFlatList: React.FC<{ | |||
| } | |||
|
|
|||
| return ( | |||
| <Flex> | |||
| <Flex style={{ width: "100%", height: "100%" }}> | |||
There was a problem hiding this comment.
the flashlist wouldn't render without this, maybe can be addressed in AboveTheFoldFlashList component to not break other surfaces if we migrate
fair, I just copied the other |
There was a problem hiding this comment.
Thanks so much for improving this - @dblandin will be very happy
brainbicycle
dismissed stale reviews from MounirDhahri and gkartalis
via
19351d2
…to brian/search-perf
brainbicycle
added
the
Squash On Green
This PR resolves PHIRE-1309
Description
Fairly minor change that replaces some lists in search with flashlist but does make nice improvements in list performance.
Before
before-low.mov
After
after-low.mov
Follow-ups
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.